[CXF-6983] org.apache.cxf.jaxrs.provider.AbstractJAXBProvider#handleJAXBException doubles the error text for unmarshalling errors

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.1.6
• Fix Version/s: 3.1.8, 3.2.0
• Component/s: JAX-RS

Environment

CXF 3.1.6 with JAXB annotated beans

• Estimated Complexity: Novice
• Assignee: Sergey Beryozkin
• Reporter: Mike Golod
• Created: 29/Jul/16 08:13
• Updated: 21/Oct/16 18:46
• Resolved: 31/Jul/16 12:26

Description

When unmarshal json payload to JAXB annotated bean sometimes we can get an UnmarshallingException (e.g. for dates). That exception already contains very descriptive message. AbstractJAXBProvider#handleExceptionStart extracts it. Then in AbstractJAXBProvider#handleJAXBException:

AbstractJAXBProvider#handleJAXBException

if (linked != null && linked.getMessage() != null) {
            Throwable cause = linked;
            while (read && cause != null) {
                if (cause instanceof XMLStreamException && cause.getMessage().startsWith("Maximum Number")) {
                    throw ExceptionUtils.toWebApplicationException(null, JAXRSUtils.toResponse(413)); 
                }
                if (cause instanceof DepthExceededStaxException) {
                    throw ExceptionUtils.toWebApplicationException(null, JAXRSUtils.toResponse(413)); 
                }
                cause = cause.getCause();
            }
            sb.append(linked.getMessage()).append(". "); // this causes the problem
        }

This code adds another message from linked exception. Message text is the same. Finally we get something like:

JAXBException occured: <error text>. <error text>.

Issue Links

• links to: GitHub Pull Request #148