[CXF-6845] Some methods in MessageUtils prone to NPE

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.9
• Fix Version/s: 3.0.10, 3.1.7, 3.2.0
• Estimated Complexity: Unknown
• Assignee: Francesco Chicchiriccò
• Reporter: Francesco Chicchiriccò
• Created: 27/Mar/16 15:47
• Updated: 14/Oct/16 14:10
• Resolved: 29/Mar/16 10:36

Description

When attempting to upgrade Syncope 1.2 from CXF 3.0.8 to 3.0.9, I receive NPE due to some methods in MessageUtils - see for example

    public static boolean getContextualBoolean(Message m, String key, boolean defaultValue) {
        Object o = m.getContextualProperty(key);
        if (o != null) {
            return PropertyUtils.isTrue(o);
        }
        return defaultValue;
    }

As you can see, if m is NULL, NPE is thrown.

See for reference the same method from 3.1.6:

    public static boolean getContextualBoolean(Message m, String key, boolean defaultValue) {
        if (m != null) {
            Object o = m.getContextualProperty(key);
            if (o != null) {
                return PropertyUtils.isTrue(o);
            }
        }
        return defaultValue;
    }