[CXF-6423] PrettyLoggingFilter tests and improvements

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.2.0
• Estimated Complexity: Moderate
• Assignee: Christian Schneider
• Reporter: Thomas Skjølberg
• Created: 27/May/15 17:40
• Updated: 28/Nov/17 10:42
• Resolved: 16/Mar/17 13:20

Description

Improvements for PrettyLoggingFilter in the cxf-rt-features-logging module:
1. use a StringReader instead of getting bytes from a String and using an InputStream (capture encoding issues at an eariler stage)
2. add parser exception handling based on whether the payload is truncated or not; return original XML if deemed invalid
3. do not call XMLStreamWriter.close() before getting contents for truncated or invalid XML because some writers misbehave (are extra helpful) in a way unfit for logging.
4.construct output StringWriter with a size based on the raw XML string size
5.additional test cases

Issue Links

• is related to: CXF-6424 AbstractLoggingInterceptor tests and improvements
• links to: GitHub Pull Request #75