[CXF-5681] OASISCatalogManager silently swallows Exceptions in getResolver()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0
• Fix Version/s: 3.0, 2.6.15, 2.7.12
• Component/s: JAX-WS Runtime
• Estimated Complexity: Unknown
• Assignee: Daniel Kulp
• Reporter: John O'Hara
• Created: 10/Apr/14 13:20
• Updated: 26/Jun/18 12:14
• Resolved: 11/Apr/14 15:11

Description

org.apache.cxf.catalog.OASISCatalogManager.getResolver() silently fails if any exceptions are thrown during the try{} block.

https://github.com/apache/cxf/blob/master/core/src/main/java/org/apache/cxf/catalog/OASISCatalogManager.java#LC107

This makes resolving issues difficult as Exceptions that contain important information are ignored.

For example, if org.apache.xml.resolver.CatalogManager is not found on the classpath (as it is in an external library), a CNFE exception is swallowed and calls to loadCatalogs() will fail to load catalogs bundled with an application. As no errors/warnings are logged, it appears that the jax-ws-catalog.xml has been loaded correctly.

IMHO, since there is already a logger defined in the OASISCatalogManager class, there should be at least an WARN message logged for exceptions within the try{} block to help resolve issues like CNFE exceptions.