[CXF-5395] ImplicitGrantService always redirect to broken redirect url

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.7.7
• Fix Version/s: 3.0.0-milestone1, 2.7.8
• Component/s: JAX-RS Security

Environment

irrelevant

• Estimated Complexity: Novice
• Assignee: Sergey Beryozkin
• Reporter: Jason Wang
• Created: 18/Nov/13 17:31
• Updated: 11/Jul/14 12:51
• Resolved: 02/Dec/13 14:09

Description

org.apache.cxf.rs.security.oauth2.services.ImplicitGrantService will build a redirectURL based on the input given to createGrant method, and redirect to such url.

I have discovered 2 issues with the building of the URL.

1. "state" is added as a fragment, not a query parameter, whereas token got added as a query parameter. According to the spec, only the access token should be appended as the fragment.

See http://tools.ietf.org/html/rfc6749#section-4.2.2
Example valid URL: http://example.com/cb#access_token=2YotnFZFEjr1zCsicMWpAA
&state=xyz&token_type=example&expires_in=3600
Actual output:
http://example.com/cb#state=xyz&access_token=2YotnFZFEjr1zCsicMWpAA
&token_type=example&expires_in=3600

2.if there are more than one OauthPermissions in the token, the OAuthUtils.convertPermissionsToScope method will simply join the them with space. For example if perms are "read" and "write", the built url will be

http://example.com/cb#state=xyz&access_token=2YotnFZFEjr1zCsicMWpAA
&token_type=example&expires_in=3600&scope=read write

Spaces are not escaped.

With those two bugs, especially the 1st one, there is no way to get oauth2 implicit flow to work with the current version of CXF.