[CXF-4727] NullPointerException in org.apache.cxf.resource.ExtendedURIResolver

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6
• Fix Version/s: 2.5.8, 2.6.5, 2.7.2

Environment

Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500)
Maven home: C:\Java\apache-maven-3.0.4\bin\..
Java version: 1.6.0_35, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_35\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

• Estimated Complexity: Unknown
• Assignee: Daniel Kulp
• Reporter: Gary D. Gregory
• Created: 02/Jan/13 22:07
• Updated: 28/Feb/13 17:27
• Resolved: 04/Jan/13 01:37

Description

I am seeing an NPE that comes up randomly at org.apache.cxf.resource.ExtendedURIResolver.close(ExtendedURIResolver.java:75).

I see the method as:

    public void close() {
        while (!resourceOpened.isEmpty()) {
            try {
                InputStream in = resourceOpened.pop();
                in.close(); 
            } catch (IOException ioe) {
                // move on...
            }
        }
    }

The NPE is on the line for "in.close();".

I have no way of reproducing this, I can just watch our builds fail on rare occasion and our tests do not log the full stack trace.

Since the catch clause does nothing, would it make sense to guard the close call? Like this:

    public void close() {
        while (!resourceOpened.isEmpty()) {
            try {
                InputStream in = resourceOpened.pop();
                if (in != null) {
                  in.close();
                }
            } catch (IOException ioe) {
                // move on...
            }
        }
    }