[CXF-4703] CXF loading performance

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7
• Fix Version/s: 2.5.8, 2.6.5, 2.7.2
• Component/s: Bus
• Labels: performance

Environment

CXF with Spring on Tomcat server

• Estimated Complexity: Novice
• Assignee: Daniel Kulp
• Reporter: Eric Chaplet
• Created: 14/Dec/12 14:29
• Updated: 28/Feb/13 17:27
• Resolved: 14/Dec/12 18:11

Description

Context : A lot of beans managed by Spring (more than 2500 beans) and about 120 endpoints managed by CXF

The loading time of the 120 web services is approximately 4 minutes, too long for me !!

I identified an area for improvement :

• CXFBusImpl

Slowness comes from getExtension(Class<T> extensionType) method
=> loc.getBeansOfType(ExtensionType);

Here, Spring is looking for beans of a Class in his big context...
Great, but if no beans are found, the next time this method is called with the same Class, this method is looking again in Spring beans (by getBeansOfType) !!!

it can be easily improved by adding an emptyBeanExtensions Set which goal is to identify wich Class has no Spring beans.

Exemple (I saved more than 1 minute loading time with this code):

public final <T> T getExtension(Class<T> extensionType)
{
Object obj = extensions.get(extensionType);
if (obj == null && !emptyExtensions.contains(extensionType))
{
ConfiguredBeanLocator loc = (ConfiguredBeanLocator) extensions.get(ConfiguredBeanLocator.class);
if (loc == null)

{ loc = createConfiguredBeanLocator(); }

if (loc != null)
{
//force loading
Collection<?> objs = loc.getBeansOfType(extensionType);
if (objs != null)
{
if (objs.isEmpty())

{ emptyExtensions.add(extensionType); }

else
{
for (Object o : objs)

{ extensions.put(extensionType, o); }

obj = extensions.get(extensionType);
}
}
}
}
if (null != obj)

{ return extensionType.cast(obj); }

return null;
}