[CXF-4507] bug in SchemaJavascriptBuilder while deserializing an Array

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.6.2
• Fix Version/s: 2.4.10, 2.5.6, 2.6.3
• Component/s: JavaScript Client
• Labels: javascript

Environment

FireFox

• Estimated Complexity: Novice
• Assignee: Daniel Kulp
• Reporter: Kayvan Arianpour
• Created: 18/Sep/12 06:54
• Updated: 08/Nov/12 17:14
• Resolved: 25/Sep/12 19:33

Description

SchemaJavascriptBuilder.java creates a JavaScript for a service, while deserializing an array it uses a variable named "arrayItem" with no value on definition.

The Problem : if an item in the array is set to null on server, the deserializer on client side set the item to the value set for the latest value set.

Here you can find the solution :

SchemaJavascriptBuilder.java line 556 : (org\apache\cxf\javascript\types)

utils.appendLine("var arrayItem;");//****************

should be read as

utils.appendLine("var arrayItem = null;");//****************

sample produced code :

function services_sal_ngs__rspPayCheque_deserialize (cxfjsutils, element) {
...
do {
var arrayItem;//*******************************
var value = null;
if (!cxfjsutils.isElementNil(curElement))

{ value = cxfjsutils.getNodeText(curElement); arrayItem = value; }
item.push(arrayItem);
curElement = cxfjsutils.getNextElementSibling(curElement);
}
...
return newobject;
}


the corrected version should be :

function services_sal_ngs__rspPayCheque_deserialize (cxfjsutils, element) {
...
do {
var arrayItem = null;//*******************************
var value = null;
if (!cxfjsutils.isElementNil(curElement)) { value = cxfjsutils.getNodeText(curElement); arrayItem = value; }

item.push(arrayItem);
curElement = cxfjsutils.getNextElementSibling(curElement);
}
...
return newobject;
}