CXF
  1. CXF
  2. CXF-4152

Make cxf-codegen-plugin m2e compatible

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.2
    • Fix Version/s: 2.6.2, 2.7.0
    • Component/s: Tooling
    • Labels:
      None
    • Estimated Complexity:
      Unknown

      Activity

      Hide
      Dennis Kieselhorst added a comment -

      Just tried with m2e 1.2: All executions are marked with an error "null (org.apache.cxf:cxf-codegen-plugin:2.7.0:wsdl2java:generate-MyService:generate-sources)". Does anyone know how to get further details?

      Show
      Dennis Kieselhorst added a comment - Just tried with m2e 1.2: All executions are marked with an error "null (org.apache.cxf:cxf-codegen-plugin:2.7.0:wsdl2java:generate-MyService:generate-sources)". Does anyone know how to get further details?
      Hide
      Daniel Kulp added a comment -

      The basics are now there. Anything else should be considered a bug/enhancement request and separate issue filed.

      The wsdl_first example loads up fine now.

      Show
      Daniel Kulp added a comment - The basics are now there. Anything else should be considered a bug/enhancement request and separate issue filed. The wsdl_first example loads up fine now.
      Hide
      Stevo Slavic added a comment -

      m2e 1.1.0 is not released yet. Snapshots can be found at Sonatype forge repository group (see here)

      Show
      Stevo Slavic added a comment - m2e 1.1.0 is not released yet. Snapshots can be found at Sonatype forge repository group (see here )
      Hide
      David J. M. Karlsen added a comment -

      Would need some guidance - have tried the same for a custom in-house plugin.
      Went for the approach to have it directly in the maven plugin (rather than creating an external eclipse plugin) - but stalled at the point where the AbstractProjectConfigurator class was needed which I could not find on central.

      There are some alternatives (using the other approach - having eclipse-based plugins for it):
      http://code.google.com/a/eclipselabs.org/p/m2e-cxf-codegen-connector/
      https://github.com/suresk/m2e-cxf-codegen-connector

      But I guess the last comment from Stevo in https://bugs.eclipse.org/bugs/show_bug.cgi?id=350081 is the best and I would need some hints on that.

      Show
      David J. M. Karlsen added a comment - Would need some guidance - have tried the same for a custom in-house plugin. Went for the approach to have it directly in the maven plugin (rather than creating an external eclipse plugin) - but stalled at the point where the AbstractProjectConfigurator class was needed which I could not find on central. There are some alternatives (using the other approach - having eclipse-based plugins for it): http://code.google.com/a/eclipselabs.org/p/m2e-cxf-codegen-connector/ https://github.com/suresk/m2e-cxf-codegen-connector But I guess the last comment from Stevo in https://bugs.eclipse.org/bugs/show_bug.cgi?id=350081 is the best and I would need some hints on that.
      Hide
      Glen Mazza added a comment -

      CXF is an open-source project, rather than pinging you're welcome to supply a patch.

      Show
      Glen Mazza added a comment - CXF is an open-source project, rather than pinging you're welcome to supply a patch.
      Hide
      David J. M. Karlsen added a comment -

      ping.

      Show
      David J. M. Karlsen added a comment - ping.
      Hide
      Stevo Slavic added a comment -

      I agree with Daniel - my request was to make plugin m2e 1.1 compatible. There are already efforts being taken to provide m2e connector for cxf-codegen-plugin (e.g. see here), I've tried it myself too, but there are few downsides:

      • when maven plugin uses custom configuration API, m2e connector (practically eclipse OSGi bundle) to read that configuration it needs plugin configuration API to be published as OSGi bundle too, or repackage it in m2e connector just to add OSGi metadata so it can be used;
      • m2e connector (lifecycle mapping metadata) that is published, installed and maintained separately from maven plugin that it connects with m2e will make using plugin harder.

      Nobody knows better cxf-codegen-plugin and how it should behave in eclipse than cxf community.

      Show
      Stevo Slavic added a comment - I agree with Daniel - my request was to make plugin m2e 1.1 compatible. There are already efforts being taken to provide m2e connector for cxf-codegen-plugin (e.g. see here ), I've tried it myself too, but there are few downsides: when maven plugin uses custom configuration API, m2e connector (practically eclipse OSGi bundle) to read that configuration it needs plugin configuration API to be published as OSGi bundle too, or repackage it in m2e connector just to add OSGi metadata so it can be used; m2e connector (lifecycle mapping metadata) that is published, installed and maintained separately from maven plugin that it connects with m2e will make using plugin harder. Nobody knows better cxf-codegen-plugin and how it should behave in eclipse than cxf community.
      Hide
      Daniel Kulp added a comment -

      I'm actually not opposed to the stuff from the second link to support m2e 1.1. That seems fairly simple to do and support. I am more or less apposed to creating the additional m2e plugin and such for 1.0 though. With 1.1 coming out, I'd go with the simpler approach.

      Show
      Daniel Kulp added a comment - I'm actually not opposed to the stuff from the second link to support m2e 1.1. That seems fairly simple to do and support. I am more or less apposed to creating the additional m2e plugin and such for 1.0 though. With 1.1 coming out, I'd go with the simpler approach.
      Hide
      Glen Mazza added a comment -

      I'm opposed to this; the plugin just needs to work within Maven's defined boundaries (which it does); it's the responsibility of those projects that wish to wrap Maven (such as m2e) to be able work properly with valid Maven plugins. Any failure of a wrapper to handle a valid Maven plugin needs to have a JIRA report sent to the wrapper, not the plugin.

      Show
      Glen Mazza added a comment - I'm opposed to this; the plugin just needs to work within Maven's defined boundaries (which it does); it's the responsibility of those projects that wish to wrap Maven (such as m2e) to be able work properly with valid Maven plugins. Any failure of a wrapper to handle a valid Maven plugin needs to have a JIRA report sent to the wrapper, not the plugin.

        People

        • Assignee:
          Daniel Kulp
          Reporter:
          Stevo Slavic
        • Votes:
          4 Vote for this issue
          Watchers:
          7 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development