[CXF-3961] SoapTransportFactory: confused exception by unknown transport protocol

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5
• Fix Version/s: 2.3.8, 2.4.5, 2.5.1
• Component/s: Core

Environment

Windows

• Estimated Complexity: Unknown
• Assignee: Daniel Kulp
• Reporter: Andrei Shakirin
• Created: 07/Dec/11 13:57
• Updated: 19/Dec/11 16:15
• Resolved: 07/Dec/11 17:31

Description

If custom transport conduit is resolved via SoapTransportFactory.getConduit(EndpointInfo ei) and transport is not found in ConduitInitiatorManager, following exception is thrown:

java.lang.NullPointerException
at org.apache.cxf.binding.soap.SoapTransportFactory.getConduit(SoapTransportFactor
y.java:228)[131:org.apache.cxf.bundle:2.4.2]

The reason is following: ConduitInitiatorManager.getConduitInitiatorForUri() doesn't throw BusException in case if transport is not found, therefore line "return conduitInit.getConduit(ei)" throws NPE.

I see two possible solutions:
A) throw BusException in ConduitInitiatorManager.getConduitInitiatorForUri() in the same way as ConduitInitiatorManager.getConduitInitiator()
B) Check for null in SoapTransportFactory

(A) is risky, because it has invluence on all calls of ConduitInitiatorManager.getConduitInitiatorForUri()
Patch for (B) is attached.