[CXF-3847] ResponseBuilderImpl.status - validation against instance var instead of parameter

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2.12, 2.4.2, 2.4.3
• Fix Version/s: 2.5, 2.4.4, 2.3.8
• Component/s: JAX-RS
• Labels: ResponseBuilder status
• Estimated Complexity: Novice
• Assignee: Sergey Beryozkin
• Reporter: Adam Johnson
• Created: 06/Oct/11 17:49
• Updated: 01/Nov/11 02:11
• Resolved: 06/Oct/11 21:05

Description

ResponseBuilderImpl.java

    public ResponseBuilder status(int s) {
        if (status < 100 || status > 599) {
            throw new IllegalArgumentException("Illegal status value : " + s);
        }
        status = s;
        return this;
    }

Noticed we were calling this with a value of 999 and not getting the IllegalArgumentException. If I add a second call immediately following I do get the exception.

Verified the issue exists in our version (2.2.12) and current version.

I expect the if statement should be checking the parameter 's' and not the instance variable 'status'.