[CXF-3789] org.apache.cxf.endpoint.ClientImpl.invoke(BindingOperationInfo, Object[], Exchange) wastes cycles

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.2
• Fix Version/s: 2.3.7, 2.4.3

Environment

Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_24, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_24\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

• Estimated Complexity: Unknown
• Assignee: Daniel Kulp
• Reporter: Gary D. Gregory
• Created: 02/Sep/11 14:36
• Updated: 19/Oct/11 17:30
• Resolved: 02/Sep/11 16:06

Description

While debugging our server, I saw in org.apache.cxf.endpoint.ClientImpl.invoke(BindingOperationInfo, Object[], Exchange):

Map<String, Object> resp = new HashMap<String, Object>();
resp.clear();

That's silly and a noop. Attaching patch to remove and do:

Map<String, Object> resp = new HashMap<String, Object>();

If you want an empty map to avoid wasting space for a rarely used feature, perhaps use:

Map<String, Object> resp = new HashMap<String, Object>(0);

or:

Map<String, Object> resp = new HashMap<String, Object>(1);