[CXF-3699] Wsdl2java generates illegal code for faults

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.4.1
• Fix Version/s: 2.4.2
• Component/s: Tooling
• Estimated Complexity: Novice
• Assignee: Daniel Kulp
• Reporter: Denis N. Antonioli
• Created: 01/Aug/11 22:53
• Updated: 19/Aug/11 03:30
• Resolved: 02/Aug/11 13:55

Description

when generating java code from a wsdl with the option to insert the @Generated annotation, the code starts with:

@Generated(value = "org.apache.cxf.tools.wsdlto.WSDLToJava", date = "2011-08-01T15:05:39.642-07:00", comments = "Apache CXF 2.4.1")
public class ... extends Exception {
@Generated(value = "org.apache.cxf.tools.wsdlto.WSDLToJava", date = "2011-08-01T15:05:39.642-07:00")

@Generated(value = "org.apache.cxf.tools.wsdlto.WSDLToJava", date = "2011-08-01T15:05:39.642-07:00")
private li.antonio.XxxServiceFault xxxServiceFault;

The bug is in tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/template/fault.vm, which starts with:
#if ($mark-generated == "true")
@Generated(value = "org.apache.cxf.tools.wsdlto.WSDLToJava", date = "$currentdate", comments = "$fullversion")
#end
public class $expClass.Name extends $exceptionSuperclass {
#if ($mark-generated == "true")
@Generated(value = "org.apache.cxf.tools.wsdlto.WSDLToJava", date = "$currentdate")
#end
#if (${suid} != "")
public static final long serialVersionUID = ${suid}L;
#end

It should be:

#if ($mark-generated == "true")
@Generated(value = "org.apache.cxf.tools.wsdlto.WSDLToJava", date = "$currentdate", comments = "$fullversion")
#end
public class $expClass.Name extends $exceptionSuperclass {
#if (${suid} != "")
#if ($mark-generated == "true")
@Generated(value = "org.apache.cxf.tools.wsdlto.WSDLToJava", date = "$currentdate")
#end
public static final long serialVersionUID = ${suid}L;
#end