[CXF-3426] CXF JMSContinuation leaks threads

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3, 2.2.11, 2.2.12, 2.3.1, 2.3.2, 2.3.3
• Fix Version/s: 2.4, 2.3.4
• Component/s: Transports
• Assignee: Willem Jiang
• Reporter: Willem Jiang
• Created: 28/Mar/11 02:40
• Updated: 18/Apr/11 12:42
• Resolved: 28/Mar/11 03:41

Description

JMSContinuation contains this method:

protected void createTimerTask(long timeout) {
        timer = new Timer();
        timer.schedule(new TimerTask() {
            public void run() {
                synchronized (JMSContinuation.this) { 
                    if (isPending) {
                        doResume();
                    }
                }
            }
        }, timeout);
    }

The 'if' statement should be changed to:

if (isPending) {
            cancelTimerTask();
            doResume();
}

The current impl causes cancel() not to be called on the Timer instance if timeout is triggered. This causes threads created by Timer instances to be leaked.

Please note: as stated above - the leak is only observable when timeouts are triggered on these continuations. If no timeouts are triggered and the orginary resume() method is called, this class does nto leak threads.