[CXF-3324] JAXRSUtils: Avoid calling Message unless it'll be logged

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.2
• Fix Version/s: 2.3.3
• Component/s: JAX-RS
• Labels: JAXRSUtils log performance

Environment

JDK 1.6

• Estimated Complexity: Novice
• Assignee: Sergey Beryozkin
• Reporter: Ka-Lok Fung
• Created: 10/Feb/11 06:34
• Updated: 01/Mar/11 15:53
• Resolved: 10/Feb/11 18:01

Description

Our performance and reliability testing has shown that Message.toString() is called many times in JAXRSUtils.selectResourceClass and JAXRSUtils.findTargetMethod. It takes up 2.5% of our CPU when these messages aren't even being logged. An image from the profiler showing this hotspot is attached.

According to our tests, if you pre-check if the message is loggable (e.g., if (LOG.isLoggable(Level.FINE))) and logging is set to the default level, the throughput is increased by 2% and the CPU time is reduced by an equal amount. The lines where this change would have the most impact are indicated in the image.