[CXF-2785] Base64Utils.decode should handle/wrap all exception types.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.6
• Fix Version/s: 2.2.8, 2.3
• Component/s: Core
• Assignee: Willem Jiang
• Reporter: Stanley J. Lewis
• Created: 26/Apr/10 17:54
• Updated: 10/May/10 18:06
• Resolved: 28/Apr/10 09:32

Description

Currently if you pass an invalid base64 encoded string to Base64Utils.decode() you can get various kinds of errors, as the code only catches at most IOException and converts that to a Base64Exception. Should really catch Exception and log it appropriately to avoid seeing errors at runtime like this:

java.lang.ArrayIndexOutOfBoundsException: 8
at org.apache.cxf.common.util.Base64Utility.processEncodeme(Base64Utility.java:345)
at org.apache.cxf.common.util.Base64Utility.decodeChunk(Base64Utility.java:164)
at org.apache.cxf.common.util.Base64Utility.decode(Base64Utility.java:180)
at org.apache.cxf.transport.http.AbstractHTTPDestination.setHeaders(AbstractHTTPDestination.java:147)
at org.apache.cxf.transport.http.AbstractHTTPDestination.setupMessage(AbstractHTTPDestination.java:333)
at org.apache.cxf.transport.http.AbstractHTTPDestination.setupMessage(AbstractHTTPDestination.java:270)
at org.apache.cxf.transport.http_jetty.JettyHTTPDestination.serviceRequest(JettyHTTPDestination.java:302)
at org.apache.cxf.transport.http_jetty.JettyHTTPDestination.doService(JettyHTTPDestination.java:276)
at org.apache.cxf.transport.http_jetty.JettyHTTPHandler.handle(JettyHTTPHandler.java:70)
...

The attached patch does this.