[CXF-2592] evaluatePreconditions() in RequestImpl should also check the If-None-Match header

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.5
• Fix Version/s: 2.2.6
• Component/s: JAX-RS
• Assignee: Unassigned
• Reporter: Kent Tong
• Created: 26/Dec/09 05:18
• Updated: 01/Feb/10 19:02
• Resolved: 29/Dec/09 15:23

Description

Currently the code is:

public ResponseBuilder evaluatePreconditions(Date lastModified, EntityTag eTag) {
ResponseBuilder rb = evaluatePreconditions(eTag);
if (rb != null)

{ return rb; }

return evaluatePreconditions(lastModified);
}
public ResponseBuilder evaluatePreconditions(EntityTag eTag)

{ String ifMatch = getHeaderValue(HttpHeaders.IF_MATCH); ... }

which is checking the If-Match header. While it is fine to check the If-Match header, it should also check the
If-None-Match header which is more often used for GET requests, along with the If-Modified-Since header.
This is what the two-argument version of evaluatePreconditions() is supposed to do.