[CXF-2544] Performance degradation in attachment logic in CXF 2.2.4

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.4
• Fix Version/s: 2.2.5
• Estimated Complexity: Moderate
• Assignee: Daniel Kulp
• Reporter: aaron pieper
• Created: 16/Nov/09 23:24
• Updated: 04/Dec/09 22:34
• Resolved: 18/Nov/09 21:19

Description

AttachmentDeserializer attaches a DelegatingInputStream to the message, which contains the attachment body. The performance of this InputStream has been significantly degraded from CXF 2.2.2 to CXF 2.2.4. For example, a 55 megabyte file used to take around three seconds to parse - now it takes over one minute.

I've attached a performance test which demonstrates the issue, using an 8 megabyte file. In CXF v2.2.2, this test takes a fraction of a second to run. In CXF v2.2.4, this test takes about 10 seconds on my machine.

I tried to track down the cause of the degradation. AttachmentDeserializer line 206 calls "new InternetHeaders(stream)" which takes a long time to complete. Since CXF v2.2.2 and CXF v2.2.4 use the same version of this InternetHeaders class, I believe it must be a change in the way the stream is being put together.