[CXF-1990] 3 CTS tests, invokeAsyncTest(for pojo, ejb and servlet) fail

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.1.4
• Component/s: JAX-WS Runtime
• Estimated Complexity: Moderate
• Assignee: Jarek Gawor
• Reporter: Chaitanya Choleti
• Created: 16/Jan/09 07:59
• Updated: 09/Feb/09 22:20
• Resolved: 19/Jan/09 20:06

Description

CTS tests jaxws.ee.w2j.document.literal.async.client.invokeAsyncCallbackTest (for pojo, ejb and servlet client ) fail ocassionally. The reason being....
In the invokeAsync method of JaxWsClientProxy class, ClientCallbacks handleMessage method is overridden. In this method first ClientCallbacks field done (boolean) is set to true and then handlers handleResponse(Response<?>) is called. In the CTS tests, if a ClientCallback.get() is called in between these two requests, a NullPointerException is thrown as the handlers state remains unchanged.

Suggested Fix : synchronize the ClientCallbacks handleResponse in the JaxWsClientProxy.
Also, ClientCallback class is a not thread safe so any state change should be done synchronously.