Uploaded image for project: 'Apache Curator'
  1. Apache Curator
  2. CURATOR-476

PathChildrenCache never gets initialized if a child dies even before a data watch is registered for it

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 4.1.0
    • Recipes
    • None

    Description

      What's happening:

      When PathChildrenCache is started with PathChildrenCache.StartMode.POST_INITIALIZED_EVENT there could be the following scenario:
      1. PCC calls getChildren("../parent") and gets the list of it's children
      2. PCC calls processChildren(...) where it puts them into it's {initialSet} – set of children whose data it will fetch and cache
      3. Later in the same method it calls getDataAndStat(..."/parent/somechild") where it calls getData(...) on this child and registers a dataWatcher for this child

      Midst of step 2&3, child node could get deleted – but since step 3 hasn't completed yet, the dataWatcher isn't triggered (since it is not even registered) and we miss the NodeDeleted event.

      Since our {initialSet} still contains the child path, the initialized event is never fired.

      The fix:

      As of now there's only one codepath to removing a path from the {initialSet} (done from the data watcher)

      The remove should also be called in the callback of our getData(..."/parent/somechild") being done in Step 3 if the resultCode=-101(KeeperException.NoNode)

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              rsouhrain Rohan Suri
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: