Uploaded image for project: 'Apache Curator'
  1. Apache Curator
  2. CURATOR-409

TestingQuorumPeerMain does not work with Zookeeper 3.5.3-beta

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.0
    • Fix Version/s: 4.0.0, 2.13.0
    • Component/s: Tests
    • Labels:
      None

      Description

      Zookeeper 3.5.3 has added a getQuorumPeer method to QuorumPeerMain https://github.com/apache/zookeeper/blob/release-3.5.3/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java#L194. TestingQuorumPeerMain has an identically named method, which is now unintentionally overridding the one in the base class.

      This causes TestingCluster to be unusable.

      20:36:41.199 [Thread-1] ERROR org.apache.curator.test.TestingZooKeeperServer - From testing server (random state: false) for instance: InstanceSpec{dataDirectory=C:\Users\Esran\AppData\Local\Temp\1494009401090-0, port=65306, electionPort=65307, quorumPort=65308, deleteDataDirectoryOnClose=true, serverId=1, tickTime=-1, maxClientCnxns=-1, customProperties={}, hostname=127.0.0.1} org.apache.curator.test.InstanceSpec@59c4b497
      java.lang.NullPointerException: null
      	at org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:158) ~[zookeeper-3.5.3-beta.jar:3.5.3-beta-8ce24f9e675cbefffb8f21a47e06b42864475a60]
      	at org.apache.curator.test.TestingZooKeeperServer$1.run(TestingZooKeeperServer.java:150) [curator-test-3.3.0.jar:3.3.0]
      	at java.lang.Thread.run(Thread.java:745) [?:1.8.0_73]
      

      The method in TestingQuorumPeerMain should be renamed.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                srdo Stig Rohde Døssing
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: