[CURATOR-395] Potential null dereference in PersistentNode

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0.0, 2.13.0
• Assignee: Jordan Zimmerman
• Reporter: Ted Yu
• Created: 23/Mar/17 22:02
• Updated: 18/Apr/17 00:00
• Resolved: 18/Apr/17 00:00

Description

            if ( localCreateMethod == null )
            {
                CreateModable<ACLBackgroundPathAndBytesable<String>> tempCreateMethod = useProtection ? client.create().creatingParentContainersIfNeeded().withProtection() : client.create().creatingParentContainersIfNeeded();
                if ( createMethod.compareAndSet(null, tempCreateMethod) )
                {
                    localCreateMethod = tempCreateMethod;
                }
            }
            localCreateMethod.withMode(getCreateMode(existingPath != null)).inBackground(backgroundCallback).forPath(createPath, data.get());

Before calling withMode(), localCreateMethod should be checked against null.

Issue Links

• links to: GitHub Pull Request #213