Uploaded image for project: 'Apache Curator'
  1. Apache Curator
  2. CURATOR-379

unfixForNamespace corrupts child path when it contains namespace

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.11.1
    • Fix Version/s: awaiting-response
    • Component/s: Framework
    • Labels:
      None

      Description

      When a child path starts with the namespace unfixForNamespace removes the namespace string, thus creating a invalid path.

      With namespace "foo" the result of unfixForNamespace("/foobar") is "bar".

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user computerlove opened a pull request:

          https://github.com/apache/curator/pull/194

          CURATOR-379 unfixForNamespace corrupts child path when it contains namespace

          When a child path starts with the namespace unfixForNamespace removes the namespace string, thus creating a invalid path.
          With namespace "foo" the result of unfixForNamespace("/foobar") is "bar".

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/computerlove/curator CURATOR-379

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/curator/pull/194.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #194


          commit 635b0e4005a0a03848ab59c9363c54d743ec2953
          Author: Marvin Bredal Lillehaug <marvin.lillehaug@kantega.no>
          Date: 2017-01-11T10:00:01Z

          CURATOR-379

          commit 2b11a9614b501abd3344acaafc46231224c570fe
          Author: Marvin Bredal Lillehaug <marvin.lillehaug@kantega.no>
          Date: 2017-01-11T10:04:49Z

          CURATOR-379


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user computerlove opened a pull request: https://github.com/apache/curator/pull/194 CURATOR-379 unfixForNamespace corrupts child path when it contains namespace When a child path starts with the namespace unfixForNamespace removes the namespace string, thus creating a invalid path. With namespace "foo" the result of unfixForNamespace("/foobar") is "bar". You can merge this pull request into a Git repository by running: $ git pull https://github.com/computerlove/curator CURATOR-379 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/curator/pull/194.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #194 commit 635b0e4005a0a03848ab59c9363c54d743ec2953 Author: Marvin Bredal Lillehaug <marvin.lillehaug@kantega.no> Date: 2017-01-11T10:00:01Z CURATOR-379 commit 2b11a9614b501abd3344acaafc46231224c570fe Author: Marvin Bredal Lillehaug <marvin.lillehaug@kantega.no> Date: 2017-01-11T10:04:49Z CURATOR-379
          Hide
          randgalt Jordan Zimmerman added a comment -

          I don't see how this issue can ever exhibit. The namespace is pre-pended going in and removed going out so it shouldn't matter. Do you have a test case that shows how this can happen? The current test case is a contrived call directly unfixForNamespace().

          Show
          randgalt Jordan Zimmerman added a comment - I don't see how this issue can ever exhibit. The namespace is pre-pended going in and removed going out so it shouldn't matter. Do you have a test case that shows how this can happen? The current test case is a contrived call directly unfixForNamespace().

            People

            • Assignee:
              Unassigned
              Reporter:
              marvin.lillehaug Marvin Bredal Lillehaug
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development