Uploaded image for project: 'Commons CSV'
  1. Commons CSV
  2. CSV-98

Line number counting is confusing

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The original code counts EOLs only (CR/LF/CRLF), starting from 0.

      Thus the line number stays as 0 until the EOL of the first line is seen.

      This is confusing: if a parsing error is detected before EOL is reached on the first line it will be reported as line 0, whereas if the error is detected after EOL is detected but before any other characters are read it will be reported as line 1. However as far as the user is concerned in both cases the syntax error is in line 1.

      The current line number should start at 0 (when nothing has been processed) and be returned as line 1 from the 1st character read up until the end of the first line.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sebb Sebb

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment