Uploaded image for project: 'Commons CSV'
  1. Commons CSV
  2. CSV-75

ExtendedBufferReader does not handle EOL consistently

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      ExtendedBufferReader checks for '\n' (LF) in the read() methods, incrementing linecount when found.

      However, the readLine() method calls BufferedReader.readLine() which treats CR, LF and CRLF equally (and drops them).

      If the code is to be flexible in what it accepts, the class should also allow for CR alone as a line terminator.

      It should work if the code increments the line counter for CR, and for LF if the previous character was not CR.

        Attachments

        1. CSV-75.patch
          1 kB
          Sebb

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sebb Sebb
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: