[CSV-246] Misplaced null test

• Type: Bug
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Affects Version/s: 1.7
• Component/s: Parser
• Assignee: Unassigned
• Reporter: Michael Ernst
• Created: 25/Jun/19 04:11
• Updated: 12/Mar/20 07:57

Description

This code appears twice in CSVFileParserTest:
final String comment = record.getComment().replace("\n", "
n");
if (comment != null) {
The test never fails and seems misplaced.
If execution gets past replace without a null pointer exception, then the variable `comment` is definitely non-null.
The test should occur before the call to replace, or perhaps is not needed. (If it's not needed, why not? The documentation of getComment() says it is allowed to return null.)

Here are the two occurrences:
https://github.com/apache/commons-csv/blob/master/src/test/java/org/apache/commons/csv/CSVFileParserTest.java#L122
https://github.com/apache/commons-csv/blob/master/src/test/java/org/apache/commons/csv/CSVFileParserTest.java#L166