[CRYPTO-95] Code should never catch Throwable

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Assignee: Sebb
• Reporter: Sebb
• Created: 30/Jun/16 11:28
• Updated: 06/Jul/16 05:51
• Resolved: 30/Jun/16 11:43

Description

As a general rule, code should never catch Throwable or Error, only Exception.

Sometimes it is necessary to catch more than just Exception, but if so, the code must be careful to rethrow certain errors, e.g.

ThreadDeath
VirtualMachineError

There may be some others

If the throwable is not logged, then it's vital to ensure that only the appropriate ones are swallowed.

But it is better to be explicit and only catch errors which are safe to handle.