Uploaded image for project: 'Crunch'
  1. Crunch
  2. CRUNCH-613

Fix FileTargetImplTest.testHandleOutputsMovesFilesToDestination instability

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.15.0
    • Component/s: Core
    • Labels:
      None

      Description

      FileTargetImplTest.testHandleOutputsMovesFilesToDestination consistently fails on my machine because it relies on the erroneous assumption that handleOutputs will preserve part indexes in file names.

      If you are lucky the part-m-00000 file created by the MR job will be copied to the destination folder with the exact same name. However it just... luck. Final index only depends on iterator order which can vary from machine to machine (OS, FS, JDK etc.)

      This test should be rewritten to not rely on a such erroneous assumption.

        Attachments

        1. CRUNCH-613.patch
          2 kB
          Clément MATHIEU
        2. CRUNCH-613b.patch
          3 kB
          Micah Whitacre

          Activity

            People

            • Assignee:
              mkwhitacre Micah Whitacre
              Reporter:
              clement@unportant.info Clément MATHIEU
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: