Uploaded image for project: 'Crunch (Retired)'
  1. Crunch (Retired)
  2. CRUNCH-612

Add support of private constructors to Avros.reflect

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.15.0
    • Core
    • None
    • Patch

    Description

      While Avro reflect supports private no-arg constructors since at least 1.4.0, see this test case, Crunch mandates this constructor to be public for deep copy. It seems like an unfortunate shortcoming rather than a conscious choice.

      Since hiding the mandatory no-arg constructor can be quite useful to avoid API pollution, let's patch AvroDeepCopier to add support of private ctor.

      Attachments

        1. CRUNCH-612.patch
          5 kB
          Clément MATHIEU

        Activity

          People

            jwills Josh Wills
            clement@unportant.info Clément MATHIEU
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: