Uploaded image for project: 'Crunch'
  1. Crunch
  2. CRUNCH-484

Add library features from spotify/crunch-lib into crunch-core

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: Core
    • Labels:
      None

      Description

      As suggested by Josh, I've patched the more generally-applicable stuff from https://github.com/spotify/crunch-lib into org.apache.crunch.lib

      Open questions:

      • Does all of this belong here?
      • Should Percentiles be renamed to Quantiles, given that you actually just specify a 0.0-1.0 range? Quantiles is more accurate, but people are more likely to search for Percentiles.
      • Would the DoFns.detach(...) functionality be better implemented as a DetachingReduceFn base class rather than a wrap-and-delegate?

        Attachments

        1. 0001-CRUNCH-484-Add-library-features-from-spotify-crunch-.patch
          39 kB
          David Whiting
        2. CRUNCH-484.patch
          40 kB
          Josh Wills
        3. CRUNCH-484b.patch
          40 kB
          Josh Wills
        4. CRUNCH-484c.patch
          40 kB
          David Whiting

          Activity

            People

            • Assignee:
              jwills Josh Wills
              Reporter:
              davw David Whiting
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: