Uploaded image for project: 'Crunch (Retired)'
  1. Crunch (Retired)
  2. CRUNCH-356

Replace deprecated Closeables.closeQuietly with explicit IOException handling

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Reopened
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • Core
    • None

    Description

      Closeables.closeQuietly was deprecated in Guava 13 and removed in Guava 16. If a consumer of crunch-core is using Guava 16+ a NoSuchMethodError could occur where Closeables.closeQuietly is being used.

      Uses of Closeable.closeQuietly should be replaced with explicit handling of IOException with logging.

      Attachments

        1. patch.diff
          2 kB
          John Leacox
        2. patch2.diff
          3 kB
          John Leacox
        3. CRUNCH-356.patch
          4 kB
          Josh Wills
        4. CRUNCH-356.patch
          6 kB
          John Leacox

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. CRUNCH-581 Remove dependency on Guava

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. CRUNCH-582 Upgrade Guava Dependency to 0.14

          • Major - Major loss of function.
          • Closed

          Activity

            People

              jwills Josh Wills
              johnlcox John Leacox
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated: