[COUCHDB-954] typo in key tree logic when latest=true

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2
• Component/s: Database Core
• Skill Level: Regular Contributors Level (Easy to Medium)
• Assignee: Adam Kocoloski
• Reporter: Adam Kocoloski
• Created: 18/Nov/10 04:30
• Updated: 26/Aug/11 03:03
• Resolved: 26/Aug/11 02:43

Description

This line

https://github.com/apache/couchdb/blob/7fe84eba9982ebb3bcaa48b7aa28fdd2e130422d/src/couchdb/couch_key_tree.erl#L195

seems like it should read KeysToGet3 = KeysToGet2 – LeafKeysFound, and then KeysToGet3 should be supplied to the following invocation of get_key_leafs_simple. I think the current code would crash if a user made an open_revs call with latest=true and a pair of revisions that have a parent/child relationship, or at least it would crash if latest=true was implemented (COUCHDB-953).