Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.3
    • Component/s: Build System
    • Labels:
      None

      Description

      A recent upgrade to mochiweb introduced a dependency on eunit but the build tools were not updated to match (mea culpa)

      This ticket includes a patch to mochiweb to make eunit completely optional (and declines to take the option). The patch has been submitted upstream (https://github.com/mochi/mochiweb/pull/22)

        Issue Links

          Activity

          Hide
          rnewson Robert Newson added a comment -


          This patch applies against 54aa7e0 of mochiweb itself. A similar patch for couchdb's imported copy to follow.

          Show
          rnewson Robert Newson added a comment - This patch applies against 54aa7e0 of mochiweb itself. A similar patch for couchdb's imported copy to follow.
          Hide
          janl Jan Lehnardt added a comment -

          I think we should address this for 1.1.0.

          Robert, should we wait for upstream to come up with the right solution (i see it is still discussed) or should be fork our local copy for the time being?

          Show
          janl Jan Lehnardt added a comment - I think we should address this for 1.1.0. Robert, should we wait for upstream to come up with the right solution (i see it is still discussed) or should be fork our local copy for the time being?
          Hide
          tilgovi Randall Leeds added a comment -

          Looks like this was done upstream.
          The original pull request was closed with a branch merge that had this commit:
          https://github.com/mochi/mochiweb/commit/cb460384c4f3a35fd5dd0190f963da4318e167a1

          I looked at the file list and noticed it didn't totally match this patch, but that was caught upstream and fixed a couple weeks later. That commit is here:
          https://github.com/mochi/mochiweb/commit/19708bd763be36b3fb314595dfd9ebfda1355d7e

          I'll merge these and post the patch.

          Show
          tilgovi Randall Leeds added a comment - Looks like this was done upstream. The original pull request was closed with a branch merge that had this commit: https://github.com/mochi/mochiweb/commit/cb460384c4f3a35fd5dd0190f963da4318e167a1 I looked at the file list and noticed it didn't totally match this patch, but that was caught upstream and fixed a couple weeks later. That commit is here: https://github.com/mochi/mochiweb/commit/19708bd763be36b3fb314595dfd9ebfda1355d7e I'll merge these and post the patch.
          Hide
          rnewson Robert Newson added a comment -

          Bumped to 1.2 as we need to upgrade mochiweb to make eunit fully optional.

          Show
          rnewson Robert Newson added a comment - Bumped to 1.2 as we need to upgrade mochiweb to make eunit fully optional.
          Hide
          janl Jan Lehnardt added a comment -

          Bump to 1.3.x.

          Show
          janl Jan Lehnardt added a comment - Bump to 1.3.x.
          Hide
          janl Jan Lehnardt added a comment -

          We are tracking the update of mochiweb in COUCHDB-1598

          Show
          janl Jan Lehnardt added a comment - We are tracking the update of mochiweb in COUCHDB-1598

            People

            • Assignee:
              rnewson Robert Newson
              Reporter:
              rnewson Robert Newson
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development