Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.3
    • Component/s: Build System
    • Labels:
      None

      Description

      A recent upgrade to mochiweb introduced a dependency on eunit but the build tools were not updated to match (mea culpa)

      This ticket includes a patch to mochiweb to make eunit completely optional (and declines to take the option). The patch has been submitted upstream (https://github.com/mochi/mochiweb/pull/22)

        Issue Links

          Activity

          Robert Newson created issue -
          Hide
          Robert Newson added a comment -


          This patch applies against 54aa7e0 of mochiweb itself. A similar patch for couchdb's imported copy to follow.

          Show
          Robert Newson added a comment - This patch applies against 54aa7e0 of mochiweb itself. A similar patch for couchdb's imported copy to follow.
          Robert Newson made changes -
          Field Original Value New Value
          Attachment 0001-make-eunit-completely-optional.patch [ 12459151 ]
          A. Bram Neijt made changes -
          Link This issue duplicates COUCHDB-940 [ COUCHDB-940 ]
          Hide
          Jan Lehnardt added a comment -

          I think we should address this for 1.1.0.

          Robert, should we wait for upstream to come up with the right solution (i see it is still discussed) or should be fork our local copy for the time being?

          Show
          Jan Lehnardt added a comment - I think we should address this for 1.1.0. Robert, should we wait for upstream to come up with the right solution (i see it is still discussed) or should be fork our local copy for the time being?
          Jan Lehnardt made changes -
          Fix Version/s 1.1 [ 12314933 ]
          Hide
          Randall Leeds added a comment -

          Looks like this was done upstream.
          The original pull request was closed with a branch merge that had this commit:
          https://github.com/mochi/mochiweb/commit/cb460384c4f3a35fd5dd0190f963da4318e167a1

          I looked at the file list and noticed it didn't totally match this patch, but that was caught upstream and fixed a couple weeks later. That commit is here:
          https://github.com/mochi/mochiweb/commit/19708bd763be36b3fb314595dfd9ebfda1355d7e

          I'll merge these and post the patch.

          Show
          Randall Leeds added a comment - Looks like this was done upstream. The original pull request was closed with a branch merge that had this commit: https://github.com/mochi/mochiweb/commit/cb460384c4f3a35fd5dd0190f963da4318e167a1 I looked at the file list and noticed it didn't totally match this patch, but that was caught upstream and fixed a couple weeks later. That commit is here: https://github.com/mochi/mochiweb/commit/19708bd763be36b3fb314595dfd9ebfda1355d7e I'll merge these and post the patch.
          Hide
          Robert Newson added a comment -

          Bumped to 1.2 as we need to upgrade mochiweb to make eunit fully optional.

          Show
          Robert Newson added a comment - Bumped to 1.2 as we need to upgrade mochiweb to make eunit fully optional.
          Robert Newson made changes -
          Fix Version/s 1.2 [ 12315198 ]
          Fix Version/s 1.1 [ 12314933 ]
          Hide
          Jan Lehnardt added a comment -

          Bump to 1.3.x.

          Show
          Jan Lehnardt added a comment - Bump to 1.3.x.
          Jan Lehnardt made changes -
          Fix Version/s 1.3 [ 12318350 ]
          Fix Version/s 1.2 [ 12315198 ]
          Hide
          Jan Lehnardt added a comment -

          We are tracking the update of mochiweb in COUCHDB-1598

          Show
          Jan Lehnardt added a comment - We are tracking the update of mochiweb in COUCHDB-1598
          Jan Lehnardt made changes -
          Link This issue duplicates COUCHDB-1598 [ COUCHDB-1598 ]
          Jan Lehnardt made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Closed Closed
          736d 11h 25m 1 Jan Lehnardt 14/Nov/12 21:31

            People

            • Assignee:
              Robert Newson
              Reporter:
              Robert Newson
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development