[COUCHDB-603] init script needlessly 'su's, and non-superuser use fails

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Won't Fix
• Component/s: Infrastructure

Environment

Unix

• Skill Level: New Contributors Level (Easy)
• Assignee: Naomi Slater
• Reporter: Chad MILLER
• Created: 18/Dec/09 17:08
• Updated: 02/Sep/18 06:29
• Resolved: 02/Sep/18 06:29

Description

The init script runs 'su' if the COUCHDB_USER variable is set, but it doesn't need to if the script is already running as that user. Add an additional condition on that test, so that normal role users can start and stop the server.

— couchdb/etc/init/couchdb.tpl.in 2009-10-02 07:10:18.475913699 -0400
+++ couchdb/etc/init/couchdb.tpl.in 2009-10-02 07:22:22.711911041 -0400
@@ -77,7 +77,7 @@
command="$command $COUCHDB_OPTIONS"
fi
mkdir -p "$RUN_DIR"

• if test -n "$COUCHDB_USER"; then
  + if test -n "$COUCHDB_USER" -a "`id -u \"$COUCHDB_USER\" 2>&1`" != "`id -u`"; then
  chown $COUCHDB_USER "$RUN_DIR"
  if su $COUCHDB_USER -c "$command" > /dev/null; then
  return $SCRIPT_OK

(Reported as bug at https://bugs.launchpad.net/ubuntu/+source/couchdb/+bug/435484 )