Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10
    • Fix Version/s: 0.10
    • Component/s: Futon
    • Labels:
      None

      Description

      Sometimes you'd like to have maximum space for browsing your views. Therefore I'd like to see a way to hide the sidebar.

      1. futon-hide-sidebar-vmx.patch
        1 kB
        Volker Mische
      2. sidebar-toggle.png
        0.5 kB
        Christopher Lenz
      3. futon-hide-sidebar-cmlenz2.patch
        6 kB
        Christopher Lenz
      4. sidebar-toggle.png
        0.8 kB
        Christopher Lenz
      5. futon-hide-sidebar-cmlenz1.patch
        6 kB
        Christopher Lenz
      6. futon-hide-sidebar-2.patch
        4 kB
        Volker Mische
      7. bg.png
        0.4 kB
        Volker Mische
      8. futon-hide-sidebar.patch
        4 kB
        Volker Mische

        Activity

        Hide
        Sam Bisbee added a comment -

        Resolved for a while. Closing.

        Show
        Sam Bisbee added a comment - Resolved for a while. Closing.
        Hide
        Jan Lehnardt added a comment -

        Volker, Christopher, just to let you guys know, I just spent three minutes hiding and showing the sidebar. it looks that cool, thanks!

        Show
        Jan Lehnardt added a comment - Volker, Christopher, just to let you guys know, I just spent three minutes hiding and showing the sidebar. it looks that cool, thanks!
        Hide
        Christopher Lenz added a comment -

        Thanks for the patch, applied in r797252.

        Show
        Christopher Lenz added a comment - Thanks for the patch, applied in r797252.
        Hide
        Volker Mische added a comment -

        Thank for the commit, it looks great. Though here's a patch that makes the animation a bit more subtly (fading out the child nodes, instead of toggling them). This patch also reduced the wobbling of the triangle a bit (with animating the #wrap before the #sidebar), I'd like to get rid of the wobbling completly but it doesn't seem to that easy to achieve.

        Show
        Volker Mische added a comment - Thank for the commit, it looks great. Though here's a patch that makes the animation a bit more subtly (fading out the child nodes, instead of toggling them). This patch also reduced the wobbling of the triangle a bit (with animating the #wrap before the #sidebar), I'd like to get rid of the wobbling completly but it doesn't seem to that easy to achieve.
        Hide
        Christopher Lenz added a comment -

        Okay, the icon needed by the cmlenz2 patch wants the sidebar-toggle.png image with the arrows, not the one with the plus/minus symbols.

        Show
        Christopher Lenz added a comment - Okay, the icon needed by the cmlenz2 patch wants the sidebar-toggle.png image with the arrows, not the one with the plus/minus symbols.
        Hide
        Christopher Lenz added a comment -

        A slightly improved version of the previous patch. Needs an updated icon.

        Show
        Christopher Lenz added a comment - A slightly improved version of the previous patch. Needs an updated icon.
        Hide
        Christopher Lenz added a comment -

        Here's a patch that adds the hide/show trigger as a graphical button (which I'll attach separately). This required a bit of rework of the layout, so that for example the header is now fixed at the top of the page.

        I'm not 100% happy with the +/- icons, and suppose that maybe a more subtle expansion triangle would be nicer. But the raw URL link is already an arrow, and I don't want two arrow things sitting next to each other. Maybe I can rework the raw URL link icon...

        Show
        Christopher Lenz added a comment - Here's a patch that adds the hide/show trigger as a graphical button (which I'll attach separately). This required a bit of rework of the layout, so that for example the header is now fixed at the top of the page. I'm not 100% happy with the +/- icons, and suppose that maybe a more subtle expansion triangle would be nicer. But the raw URL link is already an arrow, and I don't want two arrow things sitting next to each other. Maybe I can rework the raw URL link icon...
        Hide
        Christopher Lenz added a comment -

        Oh, I should have checked the patch more closely. This looks pretty nice already.

        Show
        Christopher Lenz added a comment - Oh, I should have checked the patch more closely. This looks pretty nice already.
        Hide
        Volker Mische added a comment -

        I fully agree on a nicer visual presentation. This was the main reason why I asked for a review when I first mentioned it on the mailings list. I'm looking forward what you come up with.

        About the image, it's not a second one, it's a replacement of the old one.

        Show
        Volker Mische added a comment - I fully agree on a nicer visual presentation. This was the main reason why I asked for a review when I first mentioned it on the mailings list. I'm looking forward what you come up with. About the image, it's not a second one, it's a replacement of the old one.
        Hide
        Christopher Lenz added a comment - - edited

        I agree it would be nice to be able to hide the sidebar. But I'd very much prefer a nicer visual representation of the hide/show function, and it sucks having two background image files, the second just being a trivial variation of the first. I understand why you did this, but there must be a better way

        Anyway, I plan to experiment with this in the next couple of days.

        Show
        Christopher Lenz added a comment - - edited I agree it would be nice to be able to hide the sidebar. But I'd very much prefer a nicer visual representation of the hide/show function, and it sucks having two background image files, the second just being a trivial variation of the first. I understand why you did this, but there must be a better way Anyway, I plan to experiment with this in the next couple of days.
        Hide
        Volker Mische added a comment -

        I've cleaned up the patch. In my opinion it's ready to be applied now (the bg.png is still needed).

        Show
        Volker Mische added a comment - I've cleaned up the patch. In my opinion it's ready to be applied now (the bg.png is still needed).
        Hide
        Volker Mische added a comment -

        The patched interface needs a different background image.

        Show
        Volker Mische added a comment - The patched interface needs a different background image.
        Hide
        Volker Mische added a comment -

        Patch for hiding the sidebar in Futon. What I don't like about the patch at the moment is, that it manipulates CSS with JavaScript. I guess it can be done in a much better way (perhaps with changing the whole markup a bit more).
        If I find time I'll try to clean it up, but if anyone wants to step in, feel free to do so.

        Show
        Volker Mische added a comment - Patch for hiding the sidebar in Futon. What I don't like about the patch at the moment is, that it manipulates CSS with JavaScript. I guess it can be done in a much better way (perhaps with changing the whole markup a bit more). If I find time I'll try to clean it up, but if anyone wants to step in, feel free to do so.

          People

          • Assignee:
            Christopher Lenz
            Reporter:
            Volker Mische
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development