Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Mango
    • Labels:
      None

      Description

      The renaming of source files for mango's full text adapter was not super awesome. So I fixed it to not do that. PR incoming.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4c350081d82c3fd11cc4ba7630bf379912fa490c in couchdb's branch refs/heads/COUCHDB-3378-fix-mango-full-text-detection from Paul Joseph Davis
        [ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=4c35008 ]

        Fix mango full text detection

        The check for whether full text support in mango is available was broken
        in that the mango_cursor_text module is only compiled if dreyfus exists
        while the check to use the module was a runtime check. Thus is a user
        were to add dreyfus after mango had been compiled it would have led to a
        runtime error when we attempted to use a module that didn't exist.

        This changes the check to a compile time check in both places. And now
        that its a compile time define we can remove the need to rename source
        files around which causes problems with source control seeing that file
        change depending on local configuration.

        COUCHDB-3378

        Show
        jira-bot ASF subversion and git services added a comment - Commit 4c350081d82c3fd11cc4ba7630bf379912fa490c in couchdb's branch refs/heads/ COUCHDB-3378 -fix-mango-full-text-detection from Paul Joseph Davis [ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=4c35008 ] Fix mango full text detection The check for whether full text support in mango is available was broken in that the mango_cursor_text module is only compiled if dreyfus exists while the check to use the module was a runtime check. Thus is a user were to add dreyfus after mango had been compiled it would have led to a runtime error when we attempted to use a module that didn't exist. This changes the check to a compile time check in both places. And now that its a compile time define we can remove the need to rename source files around which causes problems with source control seeing that file change depending on local configuration. COUCHDB-3378
        Show
        paul.joseph.davis Paul Joseph Davis added a comment - PR: https://github.com/apache/couchdb/pull/480
        Hide
        paul.joseph.davis Paul Joseph Davis added a comment -

        Whoops. Thought GH integration was still broken.

        Show
        paul.joseph.davis Paul Joseph Davis added a comment - Whoops. Thought GH integration was still broken.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit db2f19b8b40c12420070612acc3ed7faed45b819 in couchdb's branch refs/heads/COUCHDB-3378-fix-mango-full-text-detection from Paul Joseph Davis
        [ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=db2f19b ]

        Fix mango full text detection

        The check for whether full text support in mango is available was broken
        in that the mango_cursor_text module is only compiled if dreyfus exists
        while the check to use the module was a runtime check. Thus is a user
        were to add dreyfus after mango had been compiled it would have led to a
        runtime error when we attempted to use a module that didn't exist.

        This changes the check to a compile time check in both places. And now
        that its a compile time define we can remove the need to rename source
        files around which causes problems with source control seeing that file
        change depending on local configuration.

        COUCHDB-3378

        Show
        jira-bot ASF subversion and git services added a comment - Commit db2f19b8b40c12420070612acc3ed7faed45b819 in couchdb's branch refs/heads/ COUCHDB-3378 -fix-mango-full-text-detection from Paul Joseph Davis [ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=db2f19b ] Fix mango full text detection The check for whether full text support in mango is available was broken in that the mango_cursor_text module is only compiled if dreyfus exists while the check to use the module was a runtime check. Thus is a user were to add dreyfus after mango had been compiled it would have led to a runtime error when we attempted to use a module that didn't exist. This changes the check to a compile time check in both places. And now that its a compile time define we can remove the need to rename source files around which causes problems with source control seeing that file change depending on local configuration. COUCHDB-3378
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit db2f19b8b40c12420070612acc3ed7faed45b819 in couchdb's branch refs/heads/master from Paul Joseph Davis
        [ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=db2f19b ]

        Fix mango full text detection

        The check for whether full text support in mango is available was broken
        in that the mango_cursor_text module is only compiled if dreyfus exists
        while the check to use the module was a runtime check. Thus is a user
        were to add dreyfus after mango had been compiled it would have led to a
        runtime error when we attempted to use a module that didn't exist.

        This changes the check to a compile time check in both places. And now
        that its a compile time define we can remove the need to rename source
        files around which causes problems with source control seeing that file
        change depending on local configuration.

        COUCHDB-3378

        Show
        jira-bot ASF subversion and git services added a comment - Commit db2f19b8b40c12420070612acc3ed7faed45b819 in couchdb's branch refs/heads/master from Paul Joseph Davis [ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=db2f19b ] Fix mango full text detection The check for whether full text support in mango is available was broken in that the mango_cursor_text module is only compiled if dreyfus exists while the check to use the module was a runtime check. Thus is a user were to add dreyfus after mango had been compiled it would have led to a runtime error when we attempted to use a module that didn't exist. This changes the check to a compile time check in both places. And now that its a compile time define we can remove the need to rename source files around which causes problems with source control seeing that file change depending on local configuration. COUCHDB-3378
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 778738b1b61dbb559a0ecc2acdd8720a02cc7ec8 in couchdb's branch refs/heads/master from Paul Joseph Davis
        [ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=778738b ]

        Merge pull request #480 from apache/COUCHDB-3378-fix-mango-full-text-detection

        Fix mango full text detection

        Show
        jira-bot ASF subversion and git services added a comment - Commit 778738b1b61dbb559a0ecc2acdd8720a02cc7ec8 in couchdb's branch refs/heads/master from Paul Joseph Davis [ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=778738b ] Merge pull request #480 from apache/ COUCHDB-3378 -fix-mango-full-text-detection Fix mango full text detection
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 778738b1b61dbb559a0ecc2acdd8720a02cc7ec8 in couchdb's branch refs/heads/63012-scheduler from Paul Joseph Davis
        [ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=778738b ]

        Merge pull request #480 from apache/COUCHDB-3378-fix-mango-full-text-detection

        Fix mango full text detection

        Show
        jira-bot ASF subversion and git services added a comment - Commit 778738b1b61dbb559a0ecc2acdd8720a02cc7ec8 in couchdb's branch refs/heads/63012-scheduler from Paul Joseph Davis [ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=778738b ] Merge pull request #480 from apache/ COUCHDB-3378 -fix-mango-full-text-detection Fix mango full text detection
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit db2f19b8b40c12420070612acc3ed7faed45b819 in couchdb's branch refs/heads/COUCHDB-3376-fix-mem3-shards from Paul Joseph Davis
        [ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=db2f19b ]

        Fix mango full text detection

        The check for whether full text support in mango is available was broken
        in that the mango_cursor_text module is only compiled if dreyfus exists
        while the check to use the module was a runtime check. Thus is a user
        were to add dreyfus after mango had been compiled it would have led to a
        runtime error when we attempted to use a module that didn't exist.

        This changes the check to a compile time check in both places. And now
        that its a compile time define we can remove the need to rename source
        files around which causes problems with source control seeing that file
        change depending on local configuration.

        COUCHDB-3378

        Show
        jira-bot ASF subversion and git services added a comment - Commit db2f19b8b40c12420070612acc3ed7faed45b819 in couchdb's branch refs/heads/ COUCHDB-3376 -fix-mem3-shards from Paul Joseph Davis [ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=db2f19b ] Fix mango full text detection The check for whether full text support in mango is available was broken in that the mango_cursor_text module is only compiled if dreyfus exists while the check to use the module was a runtime check. Thus is a user were to add dreyfus after mango had been compiled it would have led to a runtime error when we attempted to use a module that didn't exist. This changes the check to a compile time check in both places. And now that its a compile time define we can remove the need to rename source files around which causes problems with source control seeing that file change depending on local configuration. COUCHDB-3378

          People

          • Assignee:
            Unassigned
            Reporter:
            paul.joseph.davis Paul Joseph Davis
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development