[COUCHDB-2956] favicon produces a stack trace on February the 29th.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.1
• Fix Version/s: 2.0.0, 1.7.0
• Component/s: HTTP Interface
• Assignee: Alexander Shorin
• Reporter: Matthew Buckett
• Created: 01/Mar/16 16:58
• Updated: 14/Mar/16 04:28
• Resolved: 14/Mar/16 04:28

Description

I was just running my couch instance today and whenever I request the
favicon (/favicon.ico) I get this in my logs:

couchdb_1 | [error] [<0.20390.0>] Uncaught error in HTTP request: {error,if_clause}
couchdb_1 | [info] [<0.20390.0>] Stacktrace:[{calendar,date_to_gregorian_days,3,
couchdb_1 |[{file,"calendar.erl"},{line,116}]},
couchdb_1 |                                   {calendar,day_of_the_week,3,
couchdb_1 |[{file,"calendar.erl"},{line,151}]},
couchdb_1 |                                   {couch_util,rfc1123_date,1,
couchdb_1 |[{file,"couch_util.erl"},{line,462}]},
couchdb_1 |                                   {couch_httpd_misc_handlers,
couchdb_1 |                                       handle_favicon_req,2,
couchdb_1 |[{file,"couch_httpd_misc_handlers.erl"},
couchdb_1 |                                        {line,53}]},
couchdb_1 |                                   {couch_httpd,handle_request_int,5,
couchdb_1 |[{file,"couch_httpd.erl"},{line,318}]},
couchdb_1 |                                   {mochiweb_http,headers,5,
couchdb_1 |[{file,"mochiweb_http.erl"},{line,94}]},
couchdb_1 |                                   {proc_lib,init_p_do_apply,3,
couchdb_1 |[{file,"proc_lib.erl"},{line,239}]}]
couchdb_1 | [info] [<0.20390.0>] 192.168.99.1 - - GET /favicon.ico 500
couchdb_1 | [error] [<0.20390.0>] httpd 500 error response:
couchdb_1 |  {"error":"unknown_error","reason":"if_clause"}

The last part of the couch code is:

rfc1123_date(UniversalTime) ->
    {{YYYY,MM,DD},{Hour,Min,Sec}} = UniversalTime,
    DayNumber = calendar:day_of_the_week({YYYY,MM,DD}),