CouchDB
  1. CouchDB
  2. COUCHDB-23

Make build system check bootstrapping

    Details

    • Type: Bug Bug
    • Status: Reopened
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Build System
    • Labels:
      None
    • Skill Level:
      Committers Level (Medium to Hard)

      Description

      If you make the bootstrap write out the svn revision ID and the build
      process check the revision ID it may be possible to error out when the user
      has done an "svn up" without bootstrapping.

        Activity

        Hide
        Paul Joseph Davis added a comment -

        Noah, care to add anything to this? I understand the make idiot proof idea but I haven't seen it as that big of a problem. I've occasionally run into the "wtf?" problems but just fall back to `./bootstrap && ./configure && ./make` to see if that works. In other words, I'd say just close this unless you feel motivated to add the check.

        Show
        Paul Joseph Davis added a comment - Noah, care to add anything to this? I understand the make idiot proof idea but I haven't seen it as that big of a problem. I've occasionally run into the "wtf?" problems but just fall back to `./bootstrap && ./configure && ./make` to see if that works. In other words, I'd say just close this unless you feel motivated to add the check.
        Hide
        Noah Slater added a comment -

        No, please leave open. I will fix this Real Soon Now.

        Show
        Noah Slater added a comment - No, please leave open. I will fix this Real Soon Now.
        Hide
        Jan Lehnardt added a comment -

        This has been fixed for quite some time.

        Show
        Jan Lehnardt added a comment - This has been fixed for quite some time.
        Hide
        Noah Slater added a comment -

        Nope, I never did this. But I still plan to. Reopening.

        Show
        Noah Slater added a comment - Nope, I never did this. But I still plan to. Reopening.
        Hide
        Jan Lehnardt added a comment -

        `make` will re run the autotools required for a proper build automatically. Isn't that what we want?

        Show
        Jan Lehnardt added a comment - `make` will re run the autotools required for a proper build automatically. Isn't that what we want?
        Hide
        Noah Slater added a comment -

        I just had to check Makefile.am and configure.ac again to make sure I wasn't missing anything. This ticket describes the situation where running make checks to see at what revision ./bootstrap was run, and prompt the user to re-run ./bootstrap if the current revision is more recent, before bailing. Same for ./configure as well. As far as I can see, we never implemented this. It's a handy check for people who are building from source. If anything changes that is used as input to ./bootstrap or ./configure then the user should be notified that they need to go back to the beginning of the process to make sure the generated files are up to date.

        Show
        Noah Slater added a comment - I just had to check Makefile.am and configure.ac again to make sure I wasn't missing anything. This ticket describes the situation where running make checks to see at what revision ./bootstrap was run, and prompt the user to re-run ./bootstrap if the current revision is more recent, before bailing. Same for ./configure as well. As far as I can see, we never implemented this. It's a handy check for people who are building from source. If anything changes that is used as input to ./bootstrap or ./configure then the user should be notified that they need to go back to the beginning of the process to make sure the generated files are up to date.
        Hide
        Jan Lehnardt added a comment -

        I understand that the specified solution isn't implemented, but but as far as I can see it isn't needed as auto* as well as ./configure are automatically re-run by make when appropriate already, obviating an explicit coding of the same procedure.

        Show
        Jan Lehnardt added a comment - I understand that the specified solution isn't implemented, but but as far as I can see it isn't needed as auto* as well as ./configure are automatically re-run by make when appropriate already, obviating an explicit coding of the same procedure.
        Hide
        Noah Slater added a comment -

        Make does indeed catch this under certain conditions, but it does not check the ./bootstrap mechanism.

        Show
        Noah Slater added a comment - Make does indeed catch this under certain conditions, but it does not check the ./bootstrap mechanism.

          People

          • Assignee:
            Noah Slater
            Reporter:
            Noah Slater
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development