CouchDB
  1. CouchDB
  2. COUCHDB-1474

jquery.couch.js: cleanup assignment for user_doc.type

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: None
    • Component/s: Futon
    • Labels:
      None
    • Environment:

      Debian/testing

      Description

      The source code for jquery.couch.js in 1.2 and git master contains:

      user_doc.type = user_doc.type = "user" || [];

      in the signup() method. This code makes little sense; thankfully it is equivalent to the old prepareUserDoc() code:

      user_doc.type = "user";

      but the extraneous assignment and test should be removed.

        Activity

        Stéphane Alnet created issue -
        Jan Lehnardt made changes -
        Field Original Value New Value
        Fix Version/s 1.4 [ 12323451 ]
        Fix Version/s 1.2.1 [ 12319457 ]
        Dirkjan Ochtman made changes -
        Fix Version/s 1.4 [ 12323451 ]
        Hide
        ASF GitHub Bot added a comment -

        GitHub user robertkowalski opened a pull request:

        https://github.com/apache/couchdb/pull/151

        remove superfluous 'user_doc.type'

        Fixes COUCHDB-1474

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/apache/couchdb fix/1474

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/couchdb/pull/151.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #151


        commit eb9aba31d02449d4d8a474264207de0e06a8f087
        Author: Robert Kowalski <rok@kowalski.gd>
        Date: 2014-02-16T20:37:44Z

        remove superfluous 'user_doc.type'

        Fixes COUCHDB-1474


        Show
        ASF GitHub Bot added a comment - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb/pull/151 remove superfluous 'user_doc.type' Fixes COUCHDB-1474 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb fix/1474 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #151 commit eb9aba31d02449d4d8a474264207de0e06a8f087 Author: Robert Kowalski <rok@kowalski.gd> Date: 2014-02-16T20:37:44Z remove superfluous 'user_doc.type' Fixes COUCHDB-1474
        Hide
        ASF subversion and git services added a comment -

        Commit ea9bc69e003426c256893f53063b24dd71b6ac46 in couchdb's branch refs/heads/master from Robert Kowalski
        [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=ea9bc69 ]

        remove superfluous 'user_doc.type'

        Fixes COUCHDB-1474

        Show
        ASF subversion and git services added a comment - Commit ea9bc69e003426c256893f53063b24dd71b6ac46 in couchdb's branch refs/heads/master from Robert Kowalski [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=ea9bc69 ] remove superfluous 'user_doc.type' Fixes COUCHDB-1474
        Hide
        Andy Wenk added a comment -

        merged the PR

        Show
        Andy Wenk added a comment - merged the PR
        Andy Wenk made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        ASF GitHub Bot added a comment -

        Github user robertkowalski closed the pull request at:

        https://github.com/apache/couchdb/pull/151

        Show
        ASF GitHub Bot added a comment - Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb/pull/151
        Hide
        ASF subversion and git services added a comment -

        Commit 0ff661b5df8b28dfdcfd577f89b210885e81b20b in couchdb-jquery-couch's branch refs/heads/import-master from Robert Kowalski
        [ https://git-wip-us.apache.org/repos/asf?p=couchdb-jquery-couch.git;h=0ff661b ]

        remove superfluous 'user_doc.type'

        Fixes COUCHDB-1474

        Show
        ASF subversion and git services added a comment - Commit 0ff661b5df8b28dfdcfd577f89b210885e81b20b in couchdb-jquery-couch's branch refs/heads/import-master from Robert Kowalski [ https://git-wip-us.apache.org/repos/asf?p=couchdb-jquery-couch.git;h=0ff661b ] remove superfluous 'user_doc.type' Fixes COUCHDB-1474

          People

          • Assignee:
            Unassigned
            Reporter:
            Stéphane Alnet
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development