CouchDB
  1. CouchDB
  2. COUCHDB-1432

[PULL REQUEST] Fix the benchmark script ./test/bench/run so it runs

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Build System
    • Labels:
      None

      Activity

      Adam Lofts created issue -
      Robert Kowalski made changes -
      Field Original Value New Value
      Assignee Robert Kowalski [ robertkowalski ]
      Hide
      ASF GitHub Bot added a comment -

      GitHub user robertkowalski opened a pull request:

      https://github.com/apache/couchdb/pull/279

      Remove broken benchmarks

      While I tried to land COUCHDB-1432 it turned out that
      /benches/run is broken in several places for a longer time and
      nobody noticed: When trying to fix it (adding a file called
      test_setup.js) to the template, we will get the next error.

      As nobody noticed that it is broken for a longer time it seems we
      currently have no need for benchmarks, and if we have that need,
      we should add new ones which reflect our current needs and are
      compatible with 2.0 too.

      You can merge this pull request into a Git repository by running:

      $ git pull https://github.com/robertkowalski/couchdb 1.x.x--broken-bench

      Alternatively you can review and apply these changes as the patch at:

      https://github.com/apache/couchdb/pull/279.patch

      To close this pull request, make a commit to your master/trunk branch
      with (at least) the following in the commit message:

      This closes #279


      commit b93bbc573502316d643ad24de0b61365713e4692
      Author: Robert Kowalski <rok@kowalski.gd>
      Date: 2014-11-08T12:30:11Z

      Remove broken benchmarks

      While I tried to land COUCHDB-1432 it turned out that
      /benches/run is broken in several places for a longer time and
      nobody noticed: When trying to fix it (adding a file called
      test_setup.js) to the template, we will get the next error.

      As nobody noticed that it is broken for a longer time it seems we
      currently have no need for benchmarks, and if we have that need,
      we should add new ones which reflect our current needs and are
      compatible with 2.0 too.


      Show
      ASF GitHub Bot added a comment - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb/pull/279 Remove broken benchmarks While I tried to land COUCHDB-1432 it turned out that /benches/run is broken in several places for a longer time and nobody noticed: When trying to fix it (adding a file called test_setup.js) to the template, we will get the next error. As nobody noticed that it is broken for a longer time it seems we currently have no need for benchmarks, and if we have that need, we should add new ones which reflect our current needs and are compatible with 2.0 too. You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb 1.x.x--broken-bench Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/279.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #279 commit b93bbc573502316d643ad24de0b61365713e4692 Author: Robert Kowalski <rok@kowalski.gd> Date: 2014-11-08T12:30:11Z Remove broken benchmarks While I tried to land COUCHDB-1432 it turned out that /benches/run is broken in several places for a longer time and nobody noticed: When trying to fix it (adding a file called test_setup.js) to the template, we will get the next error. As nobody noticed that it is broken for a longer time it seems we currently have no need for benchmarks, and if we have that need, we should add new ones which reflect our current needs and are compatible with 2.0 too.
      Hide
      ASF GitHub Bot added a comment -

      GitHub user robertkowalski opened a pull request:

      https://github.com/apache/couchdb/pull/280

      Remove leftovers from broken becnhmark

      While I tried to land COUCHDB-1432 on 1..x.x it turned out that
      /benches/run is broken in several places for a longer time and
      nobody noticed: When trying to fix it (adding a file called
      test_setup.js) to the template, we will get the next error.

      As nobody noticed that it is broken for a longer time it seems we
      currently have no need for benchmarks, and if we have that need,
      we should add new ones which reflect our current needs and are
      compatible with 2.0 too.

      This removes the leftovers of the benchmark which is also broken
      on 1.6.x for a longer, unknown time which was already deleted in
      parts for 2.0

      You can merge this pull request into a Git repository by running:

      $ git pull https://github.com/robertkowalski/couchdb broken-bench

      Alternatively you can review and apply these changes as the patch at:

      https://github.com/apache/couchdb/pull/280.patch

      To close this pull request, make a commit to your master/trunk branch
      with (at least) the following in the commit message:

      This closes #280


      commit 6fb522797bbb7be7a540b78aa0c63d1b7074f2c9
      Author: Robert Kowalski <rok@kowalski.gd>
      Date: 2014-11-08T12:34:43Z

      Remove leftovers from broken becnhmark

      While I tried to land COUCHDB-1432 on 1..x.x it turned out that
      /benches/run is broken in several places for a longer time and
      nobody noticed: When trying to fix it (adding a file called
      test_setup.js) to the template, we will get the next error.

      As nobody noticed that it is broken for a longer time it seems we
      currently have no need for benchmarks, and if we have that need,
      we should add new ones which reflect our current needs and are
      compatible with 2.0 too.

      This removes the leftovers of the benchmark which is also broken
      on 1.6.x for a longer, unknown time which was already deleted in
      parts for 2.0


      Show
      ASF GitHub Bot added a comment - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb/pull/280 Remove leftovers from broken becnhmark While I tried to land COUCHDB-1432 on 1..x.x it turned out that /benches/run is broken in several places for a longer time and nobody noticed: When trying to fix it (adding a file called test_setup.js) to the template, we will get the next error. As nobody noticed that it is broken for a longer time it seems we currently have no need for benchmarks, and if we have that need, we should add new ones which reflect our current needs and are compatible with 2.0 too. This removes the leftovers of the benchmark which is also broken on 1.6.x for a longer, unknown time which was already deleted in parts for 2.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb broken-bench Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/280.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #280 commit 6fb522797bbb7be7a540b78aa0c63d1b7074f2c9 Author: Robert Kowalski <rok@kowalski.gd> Date: 2014-11-08T12:34:43Z Remove leftovers from broken becnhmark While I tried to land COUCHDB-1432 on 1..x.x it turned out that /benches/run is broken in several places for a longer time and nobody noticed: When trying to fix it (adding a file called test_setup.js) to the template, we will get the next error. As nobody noticed that it is broken for a longer time it seems we currently have no need for benchmarks, and if we have that need, we should add new ones which reflect our current needs and are compatible with 2.0 too. This removes the leftovers of the benchmark which is also broken on 1.6.x for a longer, unknown time which was already deleted in parts for 2.0
      Hide
      ASF subversion and git services added a comment -

      Commit cf3b48e47f03dfb307b1139d2751a3580c6532c8 in couchdb's branch refs/heads/master from Robert Kowalski
      [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=cf3b48e ]

      Remove leftovers from broken becnhmark

      While I tried to land COUCHDB-1432 on 1..x.x it turned out that
      /benches/run is broken in several places for a longer time and
      nobody noticed: When trying to fix it (adding a file called
      test_setup.js) to the template, we will get the next error.

      As nobody noticed that it is broken for a longer time it seems we
      currently have no need for benchmarks, and if we have that need,
      we should add new ones which reflect our current needs and are
      compatible with 2.0 too.

      This removes the leftovers of the benchmark which is also broken
      on 1.6.x for a longer, unknown time which was already deleted in
      parts for 2.0

      Show
      ASF subversion and git services added a comment - Commit cf3b48e47f03dfb307b1139d2751a3580c6532c8 in couchdb's branch refs/heads/master from Robert Kowalski [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=cf3b48e ] Remove leftovers from broken becnhmark While I tried to land COUCHDB-1432 on 1..x.x it turned out that /benches/run is broken in several places for a longer time and nobody noticed: When trying to fix it (adding a file called test_setup.js) to the template, we will get the next error. As nobody noticed that it is broken for a longer time it seems we currently have no need for benchmarks, and if we have that need, we should add new ones which reflect our current needs and are compatible with 2.0 too. This removes the leftovers of the benchmark which is also broken on 1.6.x for a longer, unknown time which was already deleted in parts for 2.0
      Hide
      ASF GitHub Bot added a comment -

      Github user robertkowalski closed the pull request at:

      https://github.com/apache/couchdb/pull/280

      Show
      ASF GitHub Bot added a comment - Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb/pull/280
      Hide
      ASF subversion and git services added a comment -

      Commit 1545bf4244fa8787d00e189abcef51533d1ca5e8 in couchdb's branch refs/heads/1.x.x from Robert Kowalski
      [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=1545bf4 ]

      Remove broken benchmarks

      While I tried to land COUCHDB-1432 it turned out that
      /benches/run is broken in several places for a longer time and
      nobody noticed: When trying to fix it (adding a file called
      test_setup.js) to the template, we will get the next error.

      As nobody noticed that it is broken for a longer time it seems we
      currently have no need for benchmarks, and if we have that need,
      we should add new ones which reflect our current needs and are
      compatible with 2.0 too.

      Show
      ASF subversion and git services added a comment - Commit 1545bf4244fa8787d00e189abcef51533d1ca5e8 in couchdb's branch refs/heads/1.x.x from Robert Kowalski [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=1545bf4 ] Remove broken benchmarks While I tried to land COUCHDB-1432 it turned out that /benches/run is broken in several places for a longer time and nobody noticed: When trying to fix it (adding a file called test_setup.js) to the template, we will get the next error. As nobody noticed that it is broken for a longer time it seems we currently have no need for benchmarks, and if we have that need, we should add new ones which reflect our current needs and are compatible with 2.0 too.
      Hide
      ASF GitHub Bot added a comment -

      Github user robertkowalski closed the pull request at:

      https://github.com/apache/couchdb/pull/279

      Show
      ASF GitHub Bot added a comment - Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb/pull/279
      Hide
      Robert Kowalski added a comment -

      Hi Adam,

      sorry for the delay. It turned out that the benchmark was not used for years and seriously broken. We decided to delete it for now.

      Show
      Robert Kowalski added a comment - Hi Adam, sorry for the delay. It turned out that the benchmark was not used for years and seriously broken. We decided to delete it for now.
      Robert Kowalski made changes -
      Status Open [ 1 ] Resolved [ 5 ]
      Resolution Won't Fix [ 2 ]

        People

        • Assignee:
          Robert Kowalski
          Reporter:
          Adam Lofts
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development