CouchDB
  1. CouchDB
  2. COUCHDB-1377

support X-Forwarded-* headers in couch_httpd

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.1.1, 1.2
    • Fix Version/s: None
    • Component/s: HTTP Interface
    • Labels:
      None

      Description

      X-Forwarded-For, as well as X-Forwarded-Proto and X-Forwarded-Ssl, are partially supported by the couch_httpd module. However, the couch_httpd_proxy module ignores these same configuration settings when it could manipulate the headers to pass more information upstream.

        Issue Links

          Activity

          Joan Touzet made changes -
          Fix Version/s 1.6.0 [ 12325557 ]
          Dirkjan Ochtman made changes -
          Fix Version/s 1.6.0 [ 12325557 ]
          Fix Version/s 1.5.0 [ 12324309 ]
          Hide
          Jason Smith added a comment -

          Oh yes, I meant 1.5 I just misspelled it.

          Show
          Jason Smith added a comment - Oh yes, I meant 1.5 I just misspelled it.
          Hide
          Robert Newson added a comment -

          cherry pick to master so it goes in 1.5? a patch release is inappropriate for a new feature.

          Show
          Robert Newson added a comment - cherry pick to master so it goes in 1.5? a patch release is inappropriate for a new feature.
          Hide
          Jason Smith added a comment -

          This has been in production at Iris Couch since 2012-02-23, with no issues reported.

          Dirkjan Ochtman What do you mean unbitrot it? It is not in 1.4.0-rc.1. Maybe cherry-pick it to master and 1.4.x so it can make the 1.4.1 release?

          Thanks.

          Show
          Jason Smith added a comment - This has been in production at Iris Couch since 2012-02-23, with no issues reported. Dirkjan Ochtman What do you mean unbitrot it? It is not in 1.4.0-rc.1. Maybe cherry-pick it to master and 1.4.x so it can make the 1.4.1 release? Thanks.
          Dirkjan Ochtman made changes -
          Fix Version/s 1.5 [ 12324309 ]
          Fix Version/s 1.4 [ 12323451 ]
          Hide
          Dirkjan Ochtman added a comment -

          Anyone want to unbitrot this?

          Show
          Dirkjan Ochtman added a comment - Anyone want to unbitrot this?
          Alexander Shorin made changes -
          Link This issue supercedes COUCHDB-1213 [ COUCHDB-1213 ]
          Jan Lehnardt made changes -
          Fix Version/s 1.3 [ 12318350 ]
          Jan Lehnardt made changes -
          Fix Version/s 1.4 [ 12323451 ]
          Fix Version/s 1.2.1 [ 12319457 ]
          Hide
          Jason Smith added a comment -

          Backported (cherry-picked) to 1.2.x.

          https://github.com/jhs/couchdb/tree/xforwarded_1.2.x

          Etap tests pass and Max asked to run this on his favorite couch; so no news is good news

          Show
          Jason Smith added a comment - Backported (cherry-picked) to 1.2.x. https://github.com/jhs/couchdb/tree/xforwarded_1.2.x Etap tests pass and Max asked to run this on his favorite couch; so no news is good news
          Hide
          Randall Leeds added a comment -

          Patch which honors all the options.

          Show
          Randall Leeds added a comment - Patch which honors all the options.
          Randall Leeds made changes -
          Field Original Value New Value
          Attachment v1-0001-COUCHDB-1377-X-Forwarded-headers-in-proxy-module.patch [ 12509873 ]
          Randall Leeds created issue -

            People

            • Assignee:
              Randall Leeds
              Reporter:
              Randall Leeds
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development