[COUCHDB-1242] Filtered replication silently converts all query parameters to strings

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.2, 1.1
• Fix Version/s: 1.2
• Assignee: Robert Newson
• Reporter: Robert Newson
• Created: 08/Aug/11 17:17
• Updated: 23/Aug/11 10:30
• Resolved: 23/Aug/11 10:30

Description

All filtered query params are silently converted to strings. this causes tests for if (req.query.foo) to evaluate to true even for {"query_params":{"foo":false}} because "false" is true.

No clean solution exists to fix this as _changes has a GET entry point and request parameters are untyped.

Suggested fix is to scan the query_params in handle_replicate_req and throw a 400 Bad Request if any value is not a JSON string.