CouchDB
  1. CouchDB
  2. COUCHDB-1183

Shouldn't coffee-script.js be available in non-compressed form ?

    Details

    • Type: Question Question
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Skill Level:
      New Contributors Level (Easy)

      Description

      actually coffee-script.js is provided in its compressed form in share/server. While the compression may be needed this is the only file provided like this. Also I think it's better to provide all sources from which CouchDB depends (and it may be an Apache concern too) so we don't rely on any third party to get full sources.

      What I propose is to make it available uncompressed, and at build compress it. While we are here we could probably do that for other too. Other solution may be to provide both format (compressed and uncompressed) in the archive and sources. Thoughts?

        Activity

        Hide
        Jan Lehnardt added a comment -

        Bump to 1.3.x.

        Show
        Jan Lehnardt added a comment - Bump to 1.3.x.
        Hide
        Jan Lehnardt added a comment -

        On second thought, I'm only happy to maintain a local copy if we do that for all dependencies and I don't know if that makes much sense. All we depend on are relatively stable and established projects, so I don't see an immediate value of having a copy.

        Show
        Jan Lehnardt added a comment - On second thought, I'm only happy to maintain a local copy if we do that for all dependencies and I don't know if that makes much sense. All we depend on are relatively stable and established projects, so I don't see an immediate value of having a copy.
        Hide
        Benoit Chesneau added a comment -

        +1 for this solution

        Show
        Benoit Chesneau added a comment - +1 for this solution
        Hide
        Jan Lehnardt added a comment -

        The file is copied verbatim from the CoffeeScript repository (https://github.com/jashkenas/coffee-script/blob/master/extras/coffee-script.js)

        I don't think compress at build time is a good idea since it adds the coffee script build dependencies on top of our dependencies.

        I'd be happy to maintain the uncompressed version, but it is not a single file in the CoffeeScript repository. But I agree with your concerns about relying on code in a third part repository, so I would propose to keep a full source copy of the versions we bundle in http://svn.apache.org/viewvc/couchdb/vendor/

        Show
        Jan Lehnardt added a comment - The file is copied verbatim from the CoffeeScript repository ( https://github.com/jashkenas/coffee-script/blob/master/extras/coffee-script.js ) I don't think compress at build time is a good idea since it adds the coffee script build dependencies on top of our dependencies. I'd be happy to maintain the uncompressed version, but it is not a single file in the CoffeeScript repository. But I agree with your concerns about relying on code in a third part repository, so I would propose to keep a full source copy of the versions we bundle in http://svn.apache.org/viewvc/couchdb/vendor/

          People

          • Assignee:
            Unassigned
            Reporter:
            Benoit Chesneau
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development