Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.1, 1.2
    • Component/s: Database Core
    • Labels:
    • Skill Level:
      Regular Contributors Level (Easy to Medium)

      Description

      This is about the rewriter. The current 1.1.x code base contains code to support a new way of defining variables, it's in angle brackets, like <var>. This makes it possible to match things like /foo/<var>.txt which isn't possible with the :var syntax as you don't know where the variable name ends.

      Although this is an improvement, the rewriter is still very limited. As adding additional features should happen, but the 1.1 release shouldn't delayed any further, I propose to remove this functionality, in order to be able to design a better rewriter, without supporting the legacy <var> notation.

        Activity

        Hide
        Benoit Chesneau added a comment -

        applied in trunk.

        Show
        Benoit Chesneau added a comment - applied in trunk.
        Hide
        Benoit Chesneau added a comment -

        got schooled thanks! reverting changes with commit msg.

        Show
        Benoit Chesneau added a comment - got schooled thanks! reverting changes with commit msg.
        Hide
        Volker Mische added a comment -

        The savest way for this patch is to use SVN reverse merging revision 993532 [1]. I did a
        svn merge -r 993532:993531 rewrite.js
        and
        svn merge -r 993532:993531 couch_httpd_rewrite.erl

        [1] http://svn.apache.org/viewvc?view=revision&revision=993532

        Show
        Volker Mische added a comment - The savest way for this patch is to use SVN reverse merging revision 993532 [1] . I did a svn merge -r 993532:993531 rewrite.js and svn merge -r 993532:993531 couch_httpd_rewrite.erl [1] http://svn.apache.org/viewvc?view=revision&revision=993532
        Hide
        Benoit Chesneau added a comment -

        fixup.

        Show
        Benoit Chesneau added a comment - fixup.
        Hide
        Benoit Chesneau added a comment -

        patch completely reverting the "feature". I missed a bit.

        Show
        Benoit Chesneau added a comment - patch completely reverting the "feature". I missed a bit.
        Hide
        Benoit Chesneau added a comment -

        I'm +1 to remove it. Current rewriter is limited to the design we settled sometimes ago to reverse pattern matching. <var> introduced an exception to this design.

        For this reason I think it's better to remove this "feature" added during couchcamp waiting for a new rewriter. This patch does this. patch for new rewriter is coming in another ticket.

        Show
        Benoit Chesneau added a comment - I'm +1 to remove it. Current rewriter is limited to the design we settled sometimes ago to reverse pattern matching. <var> introduced an exception to this design. For this reason I think it's better to remove this "feature" added during couchcamp waiting for a new rewriter. This patch does this. patch for new rewriter is coming in another ticket.

          People

          • Assignee:
            Benoit Chesneau
            Reporter:
            Volker Mische
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development