Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.0.2
    • Fix Version/s: None
    • Component/s: Infrastructure
    • Labels:
    • Skill Level:
      New Contributors Level (Easy)

      Description

      Replace deprecated autoconf macros and use new libtool syntax

      Also use silent rules to silence the output a bit

        Activity

        Hide
        Noah Slater added a comment -

        Javier, I made quite a few changes in 1.3.x and master.

        Can you review and advise?

        Show
        Noah Slater added a comment - Javier, I made quite a few changes in 1.3.x and master. Can you review and advise?
        Hide
        Jan Lehnardt added a comment -

        Bump to 1.3

        Show
        Jan Lehnardt added a comment - Bump to 1.3
        Hide
        Jan Lehnardt added a comment -

        Bump to 1.2.

        Show
        Jan Lehnardt added a comment - Bump to 1.2.
        Hide
        Javier Jardón added a comment -

        Hello Noah, here a more datailed explanation:

        • Replace some deprecated autoconf macros:
          AM_CONFIG_HEADER -> AC_CONFIG_HEADERS and
          AC_GNU_SOURCE -> AC_USE_SYSTEM_EXTENSIONS
          AC_TRY_LINK -> AC_LINK_IFELSE
          AC_HELP_STRING -> AS_HELP_STRING
        • Use the new libtool syntax
          We need to require libtool 2.2 as minimum version: LT_PREREQ([2.2])
          And we can replace the old macros with the new syntax:
          AC_PROG_LIBTOOL, AC_DISABLE_STATIC, AC_ENABLE_SHARED -> LT_INIT([disable-static]) (enable-shared is the default)

        I can submit separate patches if you want, just tell me.

        Show
        Javier Jardón added a comment - Hello Noah, here a more datailed explanation: Replace some deprecated autoconf macros: AM_CONFIG_HEADER -> AC_CONFIG_HEADERS and AC_GNU_SOURCE -> AC_USE_SYSTEM_EXTENSIONS AC_TRY_LINK -> AC_LINK_IFELSE AC_HELP_STRING -> AS_HELP_STRING Use the new libtool syntax We need to require libtool 2.2 as minimum version: LT_PREREQ( [2.2] ) And we can replace the old macros with the new syntax: AC_PROG_LIBTOOL, AC_DISABLE_STATIC, AC_ENABLE_SHARED -> LT_INIT( [disable-static] ) (enable-shared is the default) I can submit separate patches if you want, just tell me.
        Hide
        Noah Slater added a comment -

        Upgrading the required Autotools versions may exclude some people from being able to build CouchDB without upgrading their build toolchain. Just checked OS X and these versions seem to be installed already.

        I'm not sure I understand the changes in the patch. Could you give them more of an explanation in the comments here so I understand what's being changed and why?

        Also, would it be possible for you to submit a patch which doesn't alter formatting alone? I believe the last half of the patch just changes some indentations. I'd prefer it if this was left out.

        Thanks!

        Show
        Noah Slater added a comment - Upgrading the required Autotools versions may exclude some people from being able to build CouchDB without upgrading their build toolchain. Just checked OS X and these versions seem to be installed already. I'm not sure I understand the changes in the patch. Could you give them more of an explanation in the comments here so I understand what's being changed and why? Also, would it be possible for you to submit a patch which doesn't alter formatting alone? I believe the last half of the patch just changes some indentations. I'd prefer it if this was left out. Thanks!
        Hide
        Javier Jardón added a comment -

        Update autotools configuration

        Replace deprecated autoconf macros and use new libtool syntax

        Also use silent rules to silence the output a bit

        Show
        Javier Jardón added a comment - Update autotools configuration Replace deprecated autoconf macros and use new libtool syntax Also use silent rules to silence the output a bit
        Hide
        Javier Jardón added a comment -

        I have a patch for this. Should I attach the patch here or send it to the mailing list?

        Show
        Javier Jardón added a comment - I have a patch for this. Should I attach the patch here or send it to the mailing list?

          People

          • Assignee:
            Noah Slater
            Reporter:
            Javier Jardón
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development