CouchDB
  1. CouchDB
  2. COUCHDB-1007

Removing no longer used options from the ini configuration

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1, 1.2
    • Component/s: None
    • Labels:
      None
    • Environment:

      trunk, 1.1.x

      Description

      We have some no longer used options in the .ini configuration.
      I would like to simply drop them from trunk and 1.1.x

      Patch attached

      1. COUCHDB-1007.patch
        3 kB
        Randall Leeds
      2. COUCHDB-1007.patch
        1 kB
        Filipe Manana

        Activity

        Hide
        Filipe Manana added a comment -

        Applied to trunk and branch 1.1.x

        Show
        Filipe Manana added a comment - Applied to trunk and branch 1.1.x
        Hide
        Randall Leeds added a comment -

        Yeah. You're totally right, I'll move this to 1008. Sorry for the noise.

        Show
        Randall Leeds added a comment - Yeah. You're totally right, I'll move this to 1008. Sorry for the noise.
        Hide
        Filipe Manana added a comment -

        Randall, the purpose of this patch is just to remove unused stuff, and not to add new options. COUCHDB-1008 seems more related to what you propose. Nevertheless it should go into a separate ticket/patch, just like Paul pointed out.

        Also, the extra_options should be documented (e.g., what are all the options?)
        I also prefer the nodelay options to be in socket_options, like COUCHDB-1008 proposes. This is relative of course.

        Show
        Filipe Manana added a comment - Randall, the purpose of this patch is just to remove unused stuff, and not to add new options. COUCHDB-1008 seems more related to what you propose. Nevertheless it should go into a separate ticket/patch, just like Paul pointed out. Also, the extra_options should be documented (e.g., what are all the options?) I also prefer the nodelay options to be in socket_options, like COUCHDB-1008 proposes. This is relative of course.
        Hide
        Paul Joseph Davis added a comment -

        The extra options is nice but I think should be a separate patch instead of bundling them. Also, is the nodelay in 1.1? If not then we can just remove it. If it was then we should mark it as deprecated for 1.2 and remove it after that's released.

        Show
        Paul Joseph Davis added a comment - The extra options is nice but I think should be a separate patch instead of bundling them. Also, is the nodelay in 1.1? If not then we can just remove it. If it was then we should mark it as deprecated for 1.2 and remove it after that's released.
        Hide
        Randall Leeds added a comment -

        I'd like to propose an alternative patch.

        The nodelay option is not documented in the .ini files, so I think it's fairly safe to remove it and replace with a more general option "extra_options". Parsed as an erlang term using couch_util:parse_term, this option allows to set any options allowed by mochiweb which for now includes nodelay, backlog and acceptor_pool_size.

        If anyone has strong feelings for it, we can keep nodelay in case we're paranoid about changing that out from under people who have deployed it with "true".

        Show
        Randall Leeds added a comment - I'd like to propose an alternative patch. The nodelay option is not documented in the .ini files, so I think it's fairly safe to remove it and replace with a more general option "extra_options". Parsed as an erlang term using couch_util:parse_term, this option allows to set any options allowed by mochiweb which for now includes nodelay, backlog and acceptor_pool_size. If anyone has strong feelings for it, we can keep nodelay in case we're paranoid about changing that out from under people who have deployed it with "true".
        Hide
        Benoit Chesneau added a comment -

        +1

        Show
        Benoit Chesneau added a comment - +1
        Hide
        Paul Joseph Davis added a comment -

        LGTM +1

        Show
        Paul Joseph Davis added a comment - LGTM +1

          People

          • Assignee:
            Filipe Manana
            Reporter:
            Filipe Manana
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development