[CONTINUUM-2573] Distributed builds are not distributed: they are always scheduled to the last agent defined

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Incomplete
• Affects Version/s: 1.3.6
• Component/s: Distributed Builds
• Assignee: Unassigned
• Reporter: Paolo Scapin
• Created: 18/Oct/10 03:44
• Updated: 17/Aug/11 12:12
• Resolved: 17/Aug/11 12:12

Description

When more than one agent are available for distributed build, every build is queued to the last one defined.
This way distributed builds are useless.

The issue is caused by a small bug in class org.apache.continuum.builder.distributed.manager.DefaultDistributedBuildManager, in method getOverallDistributedBuildQueueByAgentGroup, where the index "idx" ios never incremented

line 916:

int idx = 0;

then idx is checked to assign the first queue

line 932:
if ( idx == 0 )
{
whereToBeQueued = distributedBuildQueue;
size = agentBuildSize;
}

but is never incremented.

idx should be incremented at line 953, inside the for cycle.

A similar cycle in the next method (getOverallDistributedBuildQueue) is implemented correctly

Please can anybody insert a fix in the next release?