[CONTINUUM-2281] Same Recipiant will be added several times in Notification

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.3.3 (Beta), 1.3.4 (Beta)
• Fix Version/s: 1.3.4 (Beta)
• Component/s: Core system, Notifier - Mail
• Environment: Windows, Tomcat, JDK 5, Subversion
• Assignee: Jose Morales Martinez
• Reporter: Klaus Wienert
• Created: 29/Jun/09 10:32
• Updated: 04/Aug/09 10:12
• Resolved: 04/Aug/09 10:12

Description

If notifier configuration is committers = true, then for each SCM change the Author is added in To Address. Even if the Author is already a Recipient. The Author will only get one email, but the To Address will get right long.

http://svn.apache.org/repos/asf/continuum/tags/continuum-1.3.3/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java

for ( ChangeSet changeSet : changes )
{
String scmId = changeSet.getAuthor();
if ( StringUtils.isNotEmpty( scmId ) )
{
String email = developerToEmailMap.get( scmId );
if ( StringUtils.isEmpty( email ) )

{ //TODO: Add a default domain so mail address won't be required log.warn( "no email address is defined in developers list for '" + scmId + "' scm id." ); }

else

{ // TODO: set a proper name InternetAddress to = new InternetAddress( email.trim() ); log.info( "Recipient: To '" + to + "'." ); message.addRecipient( Message.RecipientType.TO, to ); }

}
}

<ciManagement>
<system>continuum</system>
<url>http://server/continuum/</url>
<notifiers>
<notifier>
<type>mail</type>
<sendOnError>true</sendOnError>
<sendOnFailure>true</sendOnFailure>
<sendOnSuccess>false</sendOnSuccess>
<sendOnWarning>true</sendOnWarning>
<configuration>
<committers>true</committers>
</configuration>
</notifier>
</notifiers>
</ciManagement>