Continuum
  1. Continuum
  2. CONTINUUM-2231

Queues page should include the prepare build queue

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.2 (Beta)
    • Fix Version/s: 1.3.3 (Beta)
    • Component/s: Parallel Builds
    • Labels:
      None

      Description

      Currently when a forced or scheduled build kicks off, there is a delay before projects appear on the Queues page.

      During this time according to the logs, they are in the 'prepare build' queue, but this is not visible through the web ui.

      This causes users to think that nothing is happening.

      The Queues page should also show what projects are in the 'prepare build' queue.

        Issue Links

          Activity

          Hide
          Maria Catherine Tan added a comment -

          Fixed in
          r776516 of 1.3.x branch
          r776518 of trunk

          Show
          Maria Catherine Tan added a comment - Fixed in r776516 of 1.3.x branch r776518 of trunk
          Hide
          Wendy Smoak added a comment - - edited

          See screen shot, the message "Prepare Build Queue is empty" is displayed even when there is a project in the queue.

          ... it's a typo in this line:

          > Modified: continuum/branches/continuum-1.3.x/continuum-webapp/src/main/webapp/WEB-INF/jsp/admin/buildQueueView.jsp
          ...
          > + <c:if test="$

          {empty prepaerBuildQueues}

          ">

          Show
          Wendy Smoak added a comment - - edited See screen shot, the message "Prepare Build Queue is empty" is displayed even when there is a project in the queue. ... it's a typo in this line: > Modified: continuum/branches/continuum-1.3.x/continuum-webapp/src/main/webapp/WEB-INF/jsp/admin/buildQueueView.jsp ... > + <c:if test="$ {empty prepaerBuildQueues} ">
          Hide
          Wendy Smoak added a comment -

          The order on the queues page is currently
          prepare build
          current build
          checkout

          I think the current build should be at the top. That's the most interesting/useful thing on the page, and when the page refreshes you can immediately see what's building.

          That probably implies a reverse chronological order, so...

          current build
          checkout
          prepare build

          What do you think?

          Show
          Wendy Smoak added a comment - The order on the queues page is currently prepare build current build checkout I think the current build should be at the top. That's the most interesting/useful thing on the page, and when the page refreshes you can immediately see what's building. That probably implies a reverse chronological order, so... current build checkout prepare build What do you think?
          Hide
          Wendy Smoak added a comment -

          or... is the 'checkout queue' only used when you first add a project, and not at all during scheduled/forced builds? In that case, maybe it should be:

          current build
          prepare build
          current checkout

          Also, this change needs a documentation update, so let's leave the issue open until that's done.

          I didn't think Queues was documented at all, but grep turned up user_guides/viewing_queues/index.apt which isn't listed on the menu!

          Show
          Wendy Smoak added a comment - or... is the 'checkout queue' only used when you first add a project, and not at all during scheduled/forced builds? In that case, maybe it should be: current build prepare build current checkout Also, this change needs a documentation update, so let's leave the issue open until that's done. I didn't think Queues was documented at all, but grep turned up user_guides/viewing_queues/index.apt which isn't listed on the menu!
          Hide
          Maria Catherine Tan added a comment -

          Fixed in
          r776901 of 1.3.x branch
          r776902 of trunk

          Thanks Wendy!

          Show
          Maria Catherine Tan added a comment - Fixed in r776901 of 1.3.x branch r776902 of trunk Thanks Wendy!
          Hide
          Wendy Smoak added a comment - - edited

          The project groups column should be links instead of plain text, like they are in the other sections on the page.

          There should be a cancel icon next to the current item in the prepare build queue.

          (These can be handled as separate issues if you want... I know you're trying to get 1.3.3 out. Let me know and I'll open them.)

          Show
          Wendy Smoak added a comment - - edited The project groups column should be links instead of plain text, like they are in the other sections on the page. There should be a cancel icon next to the current item in the prepare build queue. (These can be handled as separate issues if you want... I know you're trying to get 1.3.3 out. Let me know and I'll open them.)
          Hide
          Maria Catherine Tan added a comment -

          The reason why I did not put a cancel icon next to the current item in prepare build queue is because it's doing an svn update, so I'd like to prevent having a corrupted working copy and will need the user to do an svn cleanup.

          IIRC, previously we also don't allow cancellation while project is still updating?

          Show
          Maria Catherine Tan added a comment - The reason why I did not put a cancel icon next to the current item in prepare build queue is because it's doing an svn update, so I'd like to prevent having a corrupted working copy and will need the user to do an svn cleanup. IIRC, previously we also don't allow cancellation while project is still updating?
          Hide
          Maria Catherine Tan added a comment -

          Yes, please open another issue if you still think we should have a cancel icon for current prepare build.

          Show
          Maria Catherine Tan added a comment - Yes, please open another issue if you still think we should have a cancel icon for current prepare build.
          Hide
          Wendy Smoak added a comment -

          No problem if there's a reason not to have a way to cancel it, but everything else on the page has one so we should mention in the docs why it's not there.

          Do you mean there's a time when you can't cancel a current build? It looks like you can cancel a checkout, doesn't that suffer from the same problem? I'm looking at http://continuum.apache.org/docs/1.3.3-SNAPSHOT/administrator_guides/queues.html

          It just needs the links then, and this one can be done.

          Show
          Wendy Smoak added a comment - No problem if there's a reason not to have a way to cancel it, but everything else on the page has one so we should mention in the docs why it's not there. Do you mean there's a time when you can't cancel a current build? It looks like you can cancel a checkout, doesn't that suffer from the same problem? I'm looking at http://continuum.apache.org/docs/1.3.3-SNAPSHOT/administrator_guides/queues.html It just needs the links then, and this one can be done.
          Hide
          Maria Catherine Tan added a comment -

          added link in project group column and also reorder queues when distributed build is enabled

          777753 of 1.3.x branch
          777754 of trunk

          Show
          Maria Catherine Tan added a comment - added link in project group column and also reorder queues when distributed build is enabled 777753 of 1.3.x branch 777754 of trunk
          Hide
          Maria Catherine Tan added a comment - - edited

          need to mention in the docs why we can't cancel current prepare build

          Show
          Maria Catherine Tan added a comment - - edited need to mention in the docs why we can't cancel current prepare build

            People

            • Assignee:
              Maria Catherine Tan
              Reporter:
              Wendy Smoak
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development