Continuum
  1. Continuum
  2. CONTINUUM-2127

Configuration for Distributed Build should be visible only if Distributed Build is enabled

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.2 (Beta)
    • Fix Version/s: 1.3.2 (Beta)
    • Component/s: Distributed Builds
    • Labels:
      None

      Description

      The "Build Agents" and "Releases" menu items are only relevant if Distributed Builds are enabled and should not be visible otherwise.

      I also noticed that the Build Agent Group selection is visible in the Build Environment page, even when Distributed Build is not enabled.

        Activity

        Wendy Smoak created issue -
        Hide
        jancajas added a comment -

        Based from the discussion :
        http://www.nabble.com/Re%3A-svn-commit%3A-r751678---in--continuum-trunk%3A-continuum-api-src-main-java-org-apache-continuum-release-distributed-manager---continuum-buildagent-continuum-buildagent-api-src-main-java-org-apache-continuum-buildagent---continuum-buildagent-continuum-b-td22469769.html

        summarized the proposed changes :

        1. Add security role "continuum-release-view"
        2. Add Distributed section in Menu
        3. Move "Releases" and "Build Agents" buttons under Distributed section
        4. Releases will show only for those who has a continuum-release-view, whom for now is the sysad only
        5. Show distributed section in menu if distributed build is enabled

        Show
        jancajas added a comment - Based from the discussion : http://www.nabble.com/Re%3A-svn-commit%3A-r751678---in--continuum-trunk%3A-continuum-api-src-main-java-org-apache-continuum-release-distributed-manager---continuum-buildagent-continuum-buildagent-api-src-main-java-org-apache-continuum-buildagent---continuum-buildagent-continuum-b-td22469769.html summarized the proposed changes : 1. Add security role "continuum-release-view" 2. Add Distributed section in Menu 3. Move "Releases" and "Build Agents" buttons under Distributed section 4. Releases will show only for those who has a continuum-release-view, whom for now is the sysad only 5. Show distributed section in menu if distributed build is enabled
        Hide
        Wendy Smoak added a comment -

        Thanks, Jan. Here are a few more:

        6. only show the Build Agent Group selection on the Build Environment page if distributed build is enabled.

        Is there any other distributed build-related configuration that needs to be suppressed to avoid confusion?

        And the reverse situation:

        7. The Build Queue button should not appear when distributed build is enabled.
        (How about a 'Parallel Builds' menu section for this which appears when Distributed Build is not enabled?)

        8. The 'Add Build Queue' selection on the Schedule should not appear when distributed build is enabled.

        Is there any other parallel build-related configuration that needs to be suppressed?

        Show
        Wendy Smoak added a comment - Thanks, Jan. Here are a few more: 6. only show the Build Agent Group selection on the Build Environment page if distributed build is enabled. Is there any other distributed build-related configuration that needs to be suppressed to avoid confusion? And the reverse situation: 7. The Build Queue button should not appear when distributed build is enabled. (How about a 'Parallel Builds' menu section for this which appears when Distributed Build is not enabled?) 8. The 'Add Build Queue' selection on the Schedule should not appear when distributed build is enabled. Is there any other parallel build-related configuration that needs to be suppressed?
        Hide
        jancajas added a comment -

        6. only show the Build Agent Group selection on the Build Environment page if distributed build is enabled.

        Is there any other distributed build-related configuration that needs to be suppressed to avoid confusion?

        i think we've got it all covered.

        7. The Build Queue button should not appear when distributed build is enabled.
        (How about a 'Parallel Builds' menu section for this which appears when Distributed Build is not enabled?)

        It makes sense since parallel and distributed features are mutually exclusive.

        8. The 'Add Build Queue' selection on the Schedule should not appear when distributed build is enabled.

        Is there any other parallel build-related configuration that needs to be suppressed?

        i think we've got it all covered.

        Show
        jancajas added a comment - 6. only show the Build Agent Group selection on the Build Environment page if distributed build is enabled. Is there any other distributed build-related configuration that needs to be suppressed to avoid confusion? i think we've got it all covered. 7. The Build Queue button should not appear when distributed build is enabled. (How about a 'Parallel Builds' menu section for this which appears when Distributed Build is not enabled?) It makes sense since parallel and distributed features are mutually exclusive. 8. The 'Add Build Queue' selection on the Schedule should not appear when distributed build is enabled. Is there any other parallel build-related configuration that needs to be suppressed? i think we've got it all covered.
        Hide
        jancajas added a comment -

        attached patch.
        Created custom tag "ifBuildTypeEnabled" for portion in the jsp pages we want to hide/show if parallel/distributed build is enabled.

        sample use:

        <c1:ifBuildTypeEnabled buildType="parallel">
        </c1:ifBuildTypeEnabled>
        
        <c1:ifBuildTypeEnabled buildType="distributed">
        </c1:ifBuildTypeEnabled>
        
        Show
        jancajas added a comment - attached patch. Created custom tag "ifBuildTypeEnabled" for portion in the jsp pages we want to hide/show if parallel/distributed build is enabled. sample use: <c1:ifBuildTypeEnabled buildType= "parallel" > </c1:ifBuildTypeEnabled> <c1:ifBuildTypeEnabled buildType= "distributed" > </c1:ifBuildTypeEnabled>
        jancajas made changes -
        Field Original Value New Value
        Attachment CONTINUUM-2127-webapp.patch [ 40733 ]
        Hide
        Wendy Smoak added a comment -

        Did you catch the 'Build Agent Group' column on the Build Environments page (/continuum/admin/buildEnvList!list.action) ?

        If not, then

        9. Build Agent Group column on the Build Environments page should only be displayed if Distributed Build is enabled

        Thanks!

        Show
        Wendy Smoak added a comment - Did you catch the 'Build Agent Group' column on the Build Environments page (/continuum/admin/buildEnvList!list.action) ? If not, then 9. Build Agent Group column on the Build Environments page should only be displayed if Distributed Build is enabled Thanks!
        Hide
        jancajas added a comment -

        updated patch. thanks for pointing that out wendy.

        Show
        jancajas added a comment - updated patch. thanks for pointing that out wendy.
        jancajas made changes -
        Attachment CONTINUUM-2127-webapp-2.patch [ 40750 ]
        Maria Catherine Tan made changes -
        Assignee Maria Catherine Tan [ ctan ]
        Hide
        Maria Catherine Tan added a comment -

        Fix in revision 755471. Thanks Jan!

        added some fix to the patch

        • added continuum-manage-parallel-builds role
        • secure BuildQueue action
        • check individual permission for each distributed menu button
        Show
        Maria Catherine Tan added a comment - Fix in revision 755471. Thanks Jan! added some fix to the patch added continuum-manage-parallel-builds role secure BuildQueue action check individual permission for each distributed menu button
        Maria Catherine Tan made changes -
        Fix Version/s 1.3.2 [ 14902 ]
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 08:36:01 UTC 2015 [ 1428222961749 ]
        Mark Thomas made changes -
        Workflow jira [ 12710779 ] Default workflow, editable Closed status [ 12739551 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 21:12:18 UTC 2015 [ 1428268338676 ]
        Mark Thomas made changes -
        Workflow jira [ 12947136 ] Default workflow, editable Closed status [ 12985149 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        4d 23h 48m 1 Maria Catherine Tan 17/Mar/09 23:15

          People

          • Assignee:
            Maria Catherine Tan
            Reporter:
            Wendy Smoak
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development